Comment Reply Link: Add border support #64271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shail-mehta
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
shail-mehta
changed the title
|
Size Change: +161 B (+0.01%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
Thanks for the PR @shail-mehta 👍 Before landing this one, I'd like to seek some additional insight on how we might work toward a more curated UI, including consistent decisions across related or similar blocks. @richtabor if you get a chance can you provide some guidelines that we might be able to apply to decide when block support controls should be displayed by default or not for a block? As can be seen in this tracking issue there are a lot of new PRs open adding border support. In most cases, the need for borders is pretty niche. The same could be said for spacing (padding/margin) support too. Would it be fair to say, that if the block is primarily typographic in nature it would be better to make spacing and border controls hidden by default? So all the link related blocks like post and comment navigation links have these controls hidden to start. |
shail-mehta
force-pushed
the
add/comment-reply-link-border-support
branch
from
a53577d to
fa3e6b6
Compare
Yea, that’s a good idea. |
shail-mehta
force-pushed
the
add/comment-reply-link-border-support
branch
from
fa3e6b6 to
2bd7912
Compare
|
I have added border control and spacing control, which are hidden by default. Additionally, I have rebased the current branch. |
shail-mehta
force-pushed
the
add/comment-reply-link-border-support
branch
from
2bd7912 to
dc8ca8e
Compare
|
Flaky tests detected in dc8ca8e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10686618555
|
ramonjd
approved these changes
Sep 4, 2024
|
Thank you for the review. |
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add border block support to the
Comment Reply Linkblock.Part of #43247
Why?
Comment Reply Linkblock is missing border support.How?
Adds the border block support in block.json.
Testing Instructions
Comment Reply Linkblock's border is Configurable via Global Styles.Comment Reply Linkblock and Apply the border Styles.Comment Reply Linkblock styles take precedence over global Styles.Comment Reply Linkblock borders display correctly in both the Editor and Frontend.Screenshots or Screencast
add-border-support-in-comment-reply-link.mp4