-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Button: Replace remaining 40px default size violations [Block library 1] #65033
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@@ -29,8 +29,7 @@ export default function CommentsLegacy( { | |||
|
|||
const actions = [ | |||
<Button | |||
// TODO: Switch to `true` (40px size) if possible | |||
__next40pxDefaultSize={ false } | |||
__next40pxDefaultSize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__next40pxDefaultSize | ||
variant="secondary" | ||
onClick={ tryAgain } | ||
> | ||
{ _x( 'Try again', 'button label' ) } | ||
</Button>{ ' ' } | ||
<Button | ||
// TODO: Switch to `true` (40px size) if possible | ||
__next40pxDefaultSize={ false } | ||
__next40pxDefaultSize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -25,8 +25,7 @@ function ModalAuxiliaryActions( { onClick, isModalFullScreen } ) { | |||
|
|||
return ( | |||
<Button | |||
// TODO: Switch to `true` (40px size) if possible | |||
__next40pxDefaultSize={ false } | |||
__next40pxDefaultSize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the Modal close button hasn't had its size updated yet, so we'll need to resolve that first with the design team (#65102).
Could we perhaps revert just this instance (the fullscreen button) to the TODO state, so we can resolve those all together? The other instances in this file are ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the Modal close button hasn't had its size updated yet, so we'll need to resolve that first with the design team (#65102).
Could we perhaps revert just this instance (the fullscreen button) to the TODO state, so we can resolve those all together? The other instances in this file are ok.
Sure @mirka, I would revert this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed up in #65131
@@ -123,8 +122,7 @@ export default function ModalEdit( props ) { | |||
> | |||
<FlexItem> | |||
<Button | |||
// TODO: Switch to `true` (40px size) if possible | |||
__next40pxDefaultSize={ false } | |||
__next40pxDefaultSize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -133,8 +131,7 @@ export default function ModalEdit( props ) { | |||
</FlexItem> | |||
<FlexItem> | |||
<Button | |||
// TODO: Switch to `true` (40px size) if possible | |||
__next40pxDefaultSize={ false } | |||
__next40pxDefaultSize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -50,8 +50,7 @@ export default function MissingEdit( { attributes, clientId } ) { | |||
|
|||
const convertToHtmlButton = ( | |||
<Button | |||
// TODO: Switch to `true` (40px size) if possible | |||
__next40pxDefaultSize={ false } | |||
__next40pxDefaultSize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for helping out with this clean up! I just noticed one issue with the Modal fullscreen button, but everything else looks good 👍
@@ -25,8 +25,7 @@ function ModalAuxiliaryActions( { onClick, isModalFullScreen } ) { | |||
|
|||
return ( | |||
<Button | |||
// TODO: Switch to `true` (40px size) if possible | |||
__next40pxDefaultSize={ false } | |||
__next40pxDefaultSize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the Modal close button hasn't had its size updated yet, so we'll need to resolve that first with the design team (#65102).
Could we perhaps revert just this instance (the fullscreen button) to the TODO state, so we can resolve those all together? The other instances in this file are ok.
This is being reverted because we need to resolve this first - WordPress#65033 (comment)
Hi @mirka, I have updated PR the with the requested change. Requesting the re-review for the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks 🚀
…brary 1] (#65033) * Fix legacy comments to use 40px default button size * Fix the embed placeholder button to use 40px default button size * Fix freeform block to use 40px default button size * Fix missing block to use 40px default button size * Revert the instance for modal fullscreen button size This is being reverted because we need to resolve this first - WordPress/gutenberg#65033 (comment) Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Source: WordPress/gutenberg@c90f1c5
…brary 1] (#65033) * Fix legacy comments to use 40px default button size * Fix the embed placeholder button to use 40px default button size * Fix freeform block to use 40px default button size * Fix missing block to use 40px default button size * Revert the instance for modal fullscreen button size This is being reverted because we need to resolve this first - WordPress/gutenberg#65033 (comment) Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Source: WordPress/gutenberg@c90f1c5
…brary 1] (#65033) * Fix legacy comments to use 40px default button size * Fix the embed placeholder button to use 40px default button size * Fix freeform block to use 40px default button size * Fix missing block to use 40px default button size * Revert the instance for modal fullscreen button size This is being reverted because we need to resolve this first - WordPress/gutenberg#65033 (comment) Co-authored-by: hbhalodia <hbhalodia@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Source: WordPress/gutenberg@c90f1c5
Part of - #65018
What?
core/missing
,core/freeform
,core/comments
,core/embed
.Why?
How?
__next40pxDefaultSize={ false }
to__next40pxDefaultSize
on component.Testing Instructions