Modal: Decrease close button size #65131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Enhancement
mirka
added
the
Needs Dev Note
mirka
commented
Sep 6, 2024
Comment on lines
+106
to
+108
| /** | ||
| * The `headerActions` prop can be used to add auxiliary actions to the header, for example a fullscreen mode toggle. | ||
| */ |
There was a problem hiding this comment.
Updated the Storybook example so it shows an actual example of how this prop is used in Gutenberg.
Comment on lines
-119
to
-123
| .components-button { | ||
| position: relative; | ||
| left: $grid-unit-10; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is the horizontal offset that was removed.
Comment on lines
+328
to
+331
| <Spacer | ||
| marginBottom={ 0 } | ||
| marginLeft={ 3 } | ||
| /> |
There was a problem hiding this comment.
Baked in some gap into the component because I'm pretty sure everyone will want it.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Sep 6, 2024
|
Size Change: +8 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
Looks good! |
This was referenced Sep 26, 2024
This was referenced Sep 28, 2024
97 tasks
mirka
added
has dev note
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65102
What?
Decreases the size of the close button in the Modal component, and remove the optical adjustment to make it flush with the content width.
Why?
The current close button uses the old 36px size which will be deprecated. We need to switch it to one of the new sizes, which was discussed in #65102.
Testing Instructions
Testing Instructions for Keyboard
Use keyboard to navigate the modals.
Screenshots or screencast
CleanShot.2024-09-07.at.06.45.38.mp4
✍️ Dev Note
Modal: Buttons in
headerActionsshould use"small"sizeThe close button in the Modal component is now using the
"small"Button size (currently 24px), down from the 36px default size in the old sizing scheme.If you are using the
headerActionsprop to inject buttons beside the close button, we recommend you also use the"small"Button size variant to match.