Fix focus loss when deleting selected block in zoom out mode #65761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
getdave
approved these changes
Oct 1, 2024
jeryj
force-pushed
the
fix/delete-focus-loss
branch
from
e449719 to
bf5393d
Compare
|
The |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…ordPress#65761)" This reverts commit 467623a.
|
It's not about block selection, but where focus goes after the deletion, especially after deleting a section with a main query loop: Before - Main section deletion before.-.focus.loss.when.deleting.main.section.movBefore - General section deletion before.-.focus.returns.to.delete.button.after.delete.but.on.new.block.movAfter - Main section deletion Focus returns to canvas. after.-.deleting.main.focus.returns.to.canvas.movAfter - General section deletion Focus returns to canvas. after.-.deleting.normal.section.block.mov |
draganescu
pushed a commit
that referenced
this pull request
Oct 2, 2024
ajlende
added
the
Backport to WP 6.7 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 16, 2024
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 7ace071 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65762
What?
Moves focus to the block canvas when deleting a block via the zoom out toolbar
Why?
Focus loss is bad.
How?
__unstableContentRef.current?.focus();when deleting the block.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast