Throwaway: merge content editing with toolbar anchoring #65844
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ToggleGroupControl: Fix arrow key navigation in RTL * Add changelog Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
* Tweak sizing and overflow behavior of TabList.
* Add size and overflow playground story.
* Add "scroll into view" behavior to selected tabs.
* fit-content only on horizontal orientation
* Reduce specificity of `fit-content` to make it easier to override.
* centered label only when orientation is horizontal
* Remove unused file.
* Fix inspector controls tabs.
* Fix font library modal tabs.
* Fix style-book tabs.
* fix typo
* Add changelog entry.
* fix emotion being weird ugh
* Prevent unwanted focusable container in Firefox.
* Add fade effect.
* Fix IntersectionObserver logic.
* Feature detect IntersectionObserver to prevent tests from failing.
* Add a bit of tolerance for scroll state detection.
* Fix vertical indicator.
* Better handling of vertical overflow.
* Add a bit of scroll margin for better "scroll into view" experience.
* Horizontal fade should only happen on horizontal direction.
* Adjust for offset parent scroll state in `getElementOffsetRect`.
* Better "scroll into view" positioning heuristics ("nearest").
* Invert use of before and after to remove z-index and fix related issues.
* Make vertical indicator light blue as discussed.
* Undo most overrides in pattern/media vertical tabs.
* Clean up outdated styles previously needed for label wrapping.
* Revert vertical indicator changes and some indicator patterns/media tabs styles
* Revert vertical indicator bug fix
* Add changelog entry
* Remove outdated style.
* Address feedback
* Fix scroll bug
* Improve automatic tab scrolling behavior.
* Tweaks to prevent unit test failure and minor cleanup.
* Undo unnecessary changes.
* Improved story
* Fix scroll jumping bug.
* Scroll to active tab instead of selected (support `selectOnMove=false`).
* Fix minor visual glitch with overflow fade out indicators.
* Misc tweaks
* Fix.
* Fix changelog
* Fix changelog but it's actually true
* Fix changelog
* Make Story Book tabs nicer.
* Temp fix for scrollbar issue in Style Book tabs.
* Fix scroll bug and clean up a little.
* Simplify and clean up a bit more.
* Fix merge issues.
* Fix merge issues again.
* Make inserter patterns/media changes more minimal
* Fix outdated comment
* Fix another typo in comment.
* Minor cleanup.
* Fix bad automatic merge.
* ugh, fix again
Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>
Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>
* Update tools menus: - Write / Design order - Change description copy * update tools help text --------- Co-authored-by: mtias <matveb@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: provenself <provenself@git.wordpress.org>
Removes code related to showing/hiding inserters on hover.
* Try use select and dispatch instead of registry * Fix `setValues` * Open `useBlockBindingsUtils` * Open registration APIs * Restrict `getFieldsList` API * Update `useBlockBindingsUtils` docs * Update register/unregister bindings docs * Simplify API functions examples Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl> * Update docs * Update comments --------- Co-authored-by: Carlos Bravo <37012961+cbravobernal@users.noreply.github.com> Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl> Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org> Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
* List view: fix miscolored icons * Add forced-colors media query Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
* Update block-filters.md Added description for `blocks.getBlockAttributes` filter * Modified example and provided additional info * modified example and provided additional info Explained the parameters accepted by the filter callback function. * modified example and provided additional info Fixed parameter names. * Update docs/reference-guides/filters/block-filters.md Thanks Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md thanks for fix Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> * Update docs/reference-guides/filters/block-filters.md Thanks for the suggestion. Not aware of the format since it's my first time. Co-authored-by: Sunil Prajapati <61308756+akasunil@users.noreply.github.com> --------- Co-authored-by: davy440 <indithemes@git.wordpress.org> Co-authored-by: akasunil <sunil25393@git.wordpress.org>
Co-authored-by: draganescu <andraganescu@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: ajlende <ajlende@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
* Fix in Skip to selected block * Fix in Tool selector * Fix in URLInputButton * Fix in URLInput * Remove dead code in FlexLayoutVerticalAlignmentControl Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
* Navigator: use stable export instead of experimental export * More clear export of useNavigator --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
* Temp disable test * Sounds good. Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> --------- Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
* Export without experimental prefix * Update README * Move Storybook stories and add redirect * Add changelog entries * Fix changelog. * Fix changelog (for real?) * Fix changelog * Apply feedback. * Fix changelog * Remove alpha story. * README fix. * Fix default in README * Fix changelog * Remove `showDropdownHeader` prop and the header itself. * Added `showDropdownHeader` as deprecated. * Remove deprecation warning * Add ignores to jsdocs. Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
* Refactor utils and switch Tabs indicator animation to `transform`. * docs tweak * Update packages/components/src/tabs/styles.ts Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com> * Add RTL support. * Addressed @ciampo's comments. * Correct for antialiasing rounding. * Make antialiasing adjustment optional. * Use larger base value and revert antialiasing adjustment code. * DRY RTL * Remove RTL story (redundant since Storybook has a dynamic setting to test RTL). * Fix bug. * Fix bug (for real this time). * Add changelog entry. * De-cleverfy code. * Sync useResizeObserver with #64943 and make useTrackElementOffsetRect resilient. * Deduplicate utility and clean up. * Minor Tabs code improvement. * Replace framer motion animation with faster CSS animation. * DRY antialiasing factor. * Changelogs. * Various improvements, fixes, and feedback addressed. * Simplify. * Simplify using derived state. * Add similar useOnValueUpdate detail to Tabs. * Fix skipping animation. * Add similar detail to Tabs animation. * Fix setState depth issue. * Fix unit test error. * Add changelog entries * Fix changelog * Update test snapshot. * Depends less on React. * Switch to layout effect for `useOnValueUpdate` * Switched to transform strategy. * Fix resizing bug. * Transition border-radius too. * Undo Tabs changes (no longer relevant). * DRY animation code. * Avoid useless re-runs in effect. * Rename `activeElement` -> `selectedElement` for clarity. * Rename `--indicator-` -> `--selected-` for accuracy. * Minor tweak. * Add safe defaults to CSS custom properties. * Tweak `useSubelementAnimation`. * Fix parent missing when there's no selected option. * Update snapshots * Add docs to utility. * Added note about border-radius. --------- Co-authored-by: Marco Ciampini <marco.ciampo@gmail.com> Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org>
#65804) Co-authored-by: DaniGuardiola <daniguardiola@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
…5810) Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
* Add tag to `useBlockBindingsUtils` * Add since tag to the registration functions Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org>
* only show resize controls in normal rendering mode * get block editing mode from hook not prop - misread code elsewhere Co-authored-by: draganescu <andraganescu@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org> Co-authored-by: scruffian <scruffian@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
* Avoid errors when the fontSize is not available * remove goBack * Update packages/edit-site/src/components/global-styles/font-sizes/font-size.js --- Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: firoz2456 <firoz2456@git.wordpress.org> Co-authored-by: nith53 <nithins53@git.wordpress.org> Co-authored-by: benniledl <benniledl@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
* Fix: Shadow/Font size preset panel crashes the editor * Refactor logic Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
* Navigator: mark experimental exports as deprecated * CHANGELOG * Update JSDocs deprecation alternatives suggestions --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
* Updated intro to the package * removed examples and demos * update README.md * Query Loop reference * fixed typo * Wording improved * Interactivity API: Update and expand on the interactivity-router docs * Update the inline HTML in the callout --------- Co-authored-by: Michal Czaplinski <mmczaplinski@gmail.com>
* Composite: fix legacy implementation passing store prop * Simplify code * Improve comment * Apply same fix to the top level Composite too * CHANGELOG --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: louwie17 <louwie17@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: gigitux <gigitux@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
* Customize widgets, edit post: refactor Button usages to new component sizing * Update snapshots * Switch to compact size in the customize widgets welcome guide * Remove unused classnames, update snapshots --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
…lculating the anchor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges #65702 and #65627 for testing.