-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigator: mark experimental exports as deprecated #65802
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just have one question on the deprecation comments.
6684603
to
bd9ea19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks 🚀
Flaky tests detected in bd9ea19. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11142852428
|
* Navigator: mark experimental exports as deprecated * CHANGELOG * Update JSDocs deprecation alternatives suggestions --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
* Navigator: mark experimental exports as deprecated * CHANGELOG * Update JSDocs deprecation alternatives suggestions --- Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
What?
Part of #59418
This PR marks the following exports from
@wordpress/components
as deprecated:__experimentalNavigatorProvider
,__experimentalNavigatorScreen
,__experimentalNavigatorButton
,__experimentalNavigatorBackButton
,__experimentalNavigatorToParentButton
and__experimentalUseNavigator
.Why?
The
Navigator
is not exported also as a stable API. The stable export should be preferred over the__experimental
one.How?
Following the passive deprecation strategy highlighted in #61099
Testing Instructions
@deprecated
JSDoc tag is applied and shows as expected on the deprecated exports