-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Establish consistency regarding alignment options between the archives and categories blocks #9469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR needs to be updated to work with the current implementation of Category block. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my previous comment
Thank you for the heads-up @gziolo, a refresh is coming up real soon ❤️ |
PR refreshed, thank you for the review @gziolo ❤️ |
@nfmohit-wpmudev thanks for waiting so long to get this PR merged. It should never happen given how easy to reviews this change was. I really appreciate your willingness to refresh this PR so quickly 🥇 |
Thank you for the merge and for your kind words @gziolo ❤️ |
…rnmobile/372-use-RichText-on-Title-block * 'master' of https://github.com/WordPress/gutenberg: (22 commits) Make the modal title styling consistent (#13669) Disable navigation block for text mode. (#12185) Fix: Linting problem in modal example code (#13671) Add myself as a code owner to the annotations (#13672) Add more reviewers to CODEOWNERS.md file (#13667) Plugin: Remove jQuery heartbeat-to-hooks proxying (#13576) Workflow: Add repository CODEOWNERS file (#13604) Add a mobile minimum size for form fields (#13639) Update edit-save documentation (#13578) Alt image setting (#13631) Fix: Allow years lower than 1970 in DateTime component. (#13602) Using addQueryArgs to generate Manage All Reusable Blocks link (#13653) Bump plugin version to 5.0.0-rc.1 (#13652) Update lodash to 4.17.10 (#13651) Refreshed PR (#9469) Set default values of the width and height input fields according to the actual image dimensions (#7687) 12647 fix css color picker (#12747) Remove "we" from messages (#13644) Fix: Font size picker max width on mobile (#13264) Fix/issue 12501 menu item aria label ...
Description
This PR closes #9413 which suggests the sync up of alignment options in the archives and categories blocks. This removes the "Full" alignment option from the categories block so it stays consistent with the archives block.
How has this been tested?
This PR has been tested by going through the following steps:
Screenshots
Types of changes
This PR just removes the
full
option from thecontrols
parameter that defined the alignment options in the "Categories" block.Checklist: