-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email notifications about pattern changes #58
Comments
Does this supersede #19? |
Oops, missed that. This one is a bit more detailed, so I'll close the other one. |
Thinking through this a bit more. It seems like it wouldn't be great if the pattern creator received an email that just said, "Your pattern has been unpublished from the pattern directory" without an explanation. #105 is intended to provide an internal explanation for why a pattern status is changed, but I'm not sure it's what we'd want to put in the email either. So, if we're going to tell people when their pattern changes, we need to provide them with some resources to get more information, so that they have recourse. But we also need to do that in a way that won't open up the pattern moderators to harassment and abuse. |
Moving this out of the Initial Launch milestone because it seems like we should see how pattern moderation ends up working in practice before we try to build this. |
The Themes team has kindly agreed to sharing their email address for email notifications and communication with pattern contributors. What do you think about the following auto-notifications through If a pattern is published
If a pattern is unpublished
Can we also set it up so that these auto-notifications are automatically tagged in HelpScout with I think if we do remove a pattern permanently, reviewers can send an email through a saved reply in the Themes HelpScout instance. How does this sound? |
@angelasjin so are you thinking that these messages would be sent to both the user who created the pattern and to HelpScout? |
No, and I can see how my comment there suggests that! I think the initial email can go to the user only, but if they respond to it, I think it makes sense that it lands in |
Ok, yep, we can add a |
@angelasjin @ryelle as I'm working on this, I'm realizing we need to distinguish between patterns that have been temporarily unpublished until they have been manually reviewed (because of flags or spam filter), vs. patterns that have been unlisted from the directory after manual review, which is more likely permanent. What do you think about these: Flagged for review
Unlisted
|
This makes sense to me. I think the existing statuses should work for "flagged for review", maybe sending on these status changes:
For the unlisted patterns, we have some reason strings, but I'm actually considering moving those into the tax term description so they can be updated in the admin (and shared between JS/PHP). I also want to add two more reasons for Spam & Non-English. The way the reason is saved might change before full-launch too. It's possible a pattern might be moved from |
Does this mean the Reason taxonomy would also be registered for the pattern post type (in addition to the flag post type)? Seems like when a pattern gets unlisted, it could be assigned whatever term was the prevailing reason for its removal.
In which case the user would get two emails in quick succession. But I think that would be ok. |
Yep, right now it saves the unlisted term-ID as meta, but what you described is how I'd rather it work. Well, not exactly, because a moderator still needs to manually pick the reason, but auto-detecting could help.
👍🏻 |
When the status of a pattern changes (#56), and possibly in some other cases, the pattern author should receive an email notification about the change. This serves to ensure they are informed when e.g. a pattern is removed from the directory by a moderator for some reason, and also to alert them to possible unauthorized access to their account.
The text was updated successfully, but these errors were encountered: