-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare initial release #133
Comments
Please vote for this approach with a thumbs-up or thumbs-down emoji. Voting will close on 8 Feb 2022 at 6pm GMT. The "easy" things first: Let's decide on the version number to use. Currently the milestone is named
|
In addition to the above vote, let's discuss a bit on the scope:
My personal suggestion therefore is to limit our first release to these two modules, IMO that's good for a start. What I'm unsure about is at which stage we should ship them, should we wait for some of these more crucial enhancements being implemented first, or is it worth giving the current version out to people already (especially given that it would be a beta release anyway)? Curious to hear y'all's thoughts! cc @adamsilverstein @getsource @audrasjb @manuelRod @aristath |
@felixarntz let's also add "Create release assets" as part of the preparation. We will need a banner, a logo, and also screenshots. |
@JustinyAhin I agree that would be great to have, though I'm not sure it is a strict requirement. None of that is truly needed for a plugin. Again, I'm not saying we shouldn't have it, but I don't think it's a blocker to release. With that said, if we want to have a banner and a logo, I think we should reach out with the wider team as soon as possible and ask if there are any volunteer designers who would like to come up with something - maybe something for the chat tomorrow @bethanylang? Regarding screenshots, we can definitely get that done. |
@felixarntz I agree on that, let's not make it a blocker for the release.
Yes, that will be a good start. |
Clarifying here that the decision needed is for the vote on this comment: #133 (comment). In addition, the Needs Discussion label for the scope: #133 (comment). |
This sounds fine as long as the release is clearly labeled beta, especially since the webp approach is changing significantly. |
Voting is now closed. Based on 8 thumbs up votes and no thumbs down votes, we'll proceed with this behavior: Using 1.0.0-beta.1 for our first release. Removing the Needs Decision label. Discussion remains open for the scope items noted in #133 (comment). |
About this, I think some enhancements have been addressed already. I'd suggest we release a beta version with the two modules in their current state, and iterate on the current issues/enhancements. Releasing now also have the advantage of having more people testing the plugin, and more feedback as well. cc @bethanylang @eclarke1 @felixarntz. |
The tricky part of shipping the current version of the WebP module would be that it will result in people's sites that use it no longer having JPEG sub-size versions of their JPEG uploads. This is probably not a big deal for many, but I'm wary of shipping it because it is in a way "destructive" behavior. I'd feel more comfortable if we had some implementation of having JPEG and WebP being generated. |
Please vote for this approach with a thumbs-up or thumbs-down emoji. Voting will close on Tuesday 1 March 2022 at 6pm GMT. Thumbs up 👍 : We will ship the initial release of the plugin with the WebP module in its current version, where it no longer generates JPEG images. Thumbs down 👎 : We will ship the initial release of the plugin without the WebP module. Heart ❤️ : We will delay the initial release until the WebP module has received support for generating both JPEG and WebP sizes. We also welcome your thoughts on why you voted the way that you did in the comments on the issue. Thank you! |
@bethanylang We may need to put a third option here like "We will delay the initial release until the WebP module has received support for generating both JPEG and WebP sizes." In that same sense, maybe the second option should be clarified that that would mean releasing a version that doesn't have the WebP module at all. |
@felixarntz Updated! |
Leaving an update here on the state of the WebP module: We still have the vote going on from #133 (comment) which ends March 1, but there is a chance that the essential parts of the One more issue that would be great to complete before beta release is #61, since it touches default behavior of the overall plugin. |
Formally closing the vote here as the WebP module has received support for generating both JPEG and WebP sizes, so this is good to go for the initial release! 🎉 |
Providing an update here after today's chat:
|
Important release update:
|
Quick update: The plugin repository is now properly configured with the |
A lot of work has already gone into this plugin, so it's about time we get to the most important stuff - release it! 🚢
This issue should serve as a bit of an overview for the things we need to cover before our initial release. See the tasks below:
The text was updated successfully, but these errors were encountered: