Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare the 1.0.0-beta.1 release #208

Merged
merged 27 commits into from
Mar 7, 2022
Merged

Prepare the 1.0.0-beta.1 release #208

merged 27 commits into from
Mar 7, 2022

Conversation

felixarntz
Copy link
Member

Summary

Fixes #133

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

manuelRod and others added 26 commits January 28, 2022 12:50
@manuelRod
Adding new supported wp setups for perflab_aea_get_path_from_resource…
780b098 
…_url.

Changing hooks to capture enqueued scripts/styles and inlines.
@manuelRod
Merge branch 'add/sitehealth-enqueued-assets' into add/sitehealth-enq…
306bbec 
…ueued-assets-enhance
@dainemawer
Added admin pointer
f912117
@dainemawer
Fixed linting issues
f256280
@dainemawer
Removed meta calls, only render pointer on certain screens, cleaned u…
cc9337e 
…p conditional logic flow
@mitogh
Access to the correct properties
13002ef 
For the most part the `elseif` block won't be reached still
in the event that it is, the properties were incorrectly
accessed.
@dainemawer
Fixed merge conflict
2108dd2
@felixarntz
Mark Site Health Audit Enqueued Assets module as experimental for now.
34bb7df
@mitogh
Merge pull request #203 from WordPress/fix/invalid-properties
7a03620 
Fix typo to access to the correct image properties
@manuelRod
nitpicks from PR review.
fb3418e
@mitogh
Removal of additional indentation level.
ab67d1e
@mitogh @felixarntz
Create admin url using admin_url function.
bfc9c91 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
@mitogh
Update hook and function definition
906dea1 
Make sure the function is only added when need it.
@mitogh @felixarntz
Replace constant with string literal instead.
8725a0c 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
@mitogh @felixarntz
Replace constant with string literal instead.
3a55053 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
@mitogh
Merge branch 'feature/add-admin-pointer' of github.com:WordPress/perf…
f196b06 
…ormance into feature/add-admin-pointer
@mitogh
Removal of not used constant
33ffd46
@mitogh
Removal of empty space
a4d49a9
@mitogh @felixarntz
Removal of non required concatenation.
a60ebc1 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
@mitogh
Fix linting error
ee57d47
@felixarntz
Merge pull request #205 from WordPress/update/sh-audit-enqueued-asset…
e78f9c6 
…s-experimental

Mark Site Health Audit Enqueued Assets module as experimental for now.
@felixarntz
Ensure empty return values from `perflab_aea_get_path_from_resource_u…
493a5c5 
…rl()` are properly handled.
@felixarntz
Merge pull request #136 from manuelRod/add/sitehealth-enqueued-assets…
675bca2 
…-enhance

Enhance detection of enqueued frontend assets
@mitogh @adamsilverstein
Removing non required space.
b3ea66e 
Co-authored-by: Adam Silverstein <adamjs@google.com>
@mitogh
Merge pull request #199 from WordPress/feature/add-admin-pointer
fa5c12f 
Added admin pointer
@felixarntz
Prepare for 1.0.0-beta.1 release.
d920e9b
@felixarntz felixarntz added [Type] Documentation Documentation to be added or enhanced Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Mar 7, 2022
@felixarntz felixarntz requested a review from audrasjb as a code owner March 7, 2022 19:08
@felixarntz felixarntz requested a review from tillkruss March 7, 2022 19:15
mitogh
mitogh requested changes Mar 7, 2022
View reviewed changes
readme.txt Outdated Show resolved Hide resolved
mitogh
mitogh reviewed Mar 7, 2022
View reviewed changes
admin/load.php Show resolved Hide resolved
adamsilverstein
adamsilverstein approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@felixarntz felixarntz merged commit ef0d26b into trunk Mar 7, 2022
@felixarntz felixarntz deleted the release/1.0.0-beta.1 branch March 7, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitogh mitogh mitogh approved these changes

@adamsilverstein adamsilverstein adamsilverstein approved these changes

@audrasjb audrasjb Awaiting requested review from audrasjb

@getsource getsource Awaiting requested review from getsource

@tillkruss tillkruss Awaiting requested review from tillkruss

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Documentation Documentation to be added or enhanced
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare initial release
5 participants
@felixarntz @adamsilverstein @mitogh @manuelRod @dainemawer