Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plugin name #3

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Add plugin name #3

merged 1 commit into from
Nov 25, 2021

Conversation

ThierryA
Copy link
Member

@ThierryA ThierryA commented Nov 25, 2021 •
edited
Loading

Addresses issue #1 based on the vote from the majority to name the plugin Performance Lab.

I went for perflab for CONSTANTS and prefixes which may still be debatable, to me it is still readable and considerably shorter.

@ThierryA ThierryA linked an issue Nov 25, 2021 that may be closed by this pull request
Define basic module specification #2
Closed
@ThierryA ThierryA removed a link to an issue Nov 25, 2021
Define basic module specification #2
Closed
@ThierryA ThierryA linked an issue Nov 25, 2021 that may be closed by this pull request
Define name for the performance plugin #1
Closed
aristath
aristath approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aristath aristath merged commit b9ae163 into trunk Nov 25, 2021
@aristath aristath deleted the add/1-add-plugin-name branch November 25, 2021 13:05
@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Dec 16, 2021
@mxbclang mxbclang mentioned this pull request Apr 18, 2022
Closed
@gerardv gerardv mentioned this pull request Feb 18, 2023
Closed
This was referenced May 22, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath aristath approved these changes

@felixarntz felixarntz Awaiting requested review from felixarntz

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define name for the performance plugin
3 participants
@ThierryA @aristath @felixarntz