Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define name for the performance plugin #1

Closed
felixarntz opened this issue Nov 23, 2021 · 17 comments · Fixed by #3
Closed

Define name for the performance plugin #1

felixarntz opened this issue Nov 23, 2021 · 17 comments · Fixed by #3
Assignees
Labels
Infrastructure Issues for the overall performance plugin infrastructure

Comments

@felixarntz
Copy link
Member

As outlined in the original proposal doc, the performance plugin doesn't have a name yet. Some ideas were previously discussed in the doc and on Slack, but we can follow up here.

Once a name (and slug!) have been decided for, we need to replace the following in the scaffolded codebase:

  • TODO-SLUG with plugin slug/textdomain
  • TODO-NAME with (human-friendly) plugin name
  • todo_snakecaseslug with snake_case version of the plugin slug (e.g. prefix for functions, options, etc.)
  • TODO_CONSTANTSLUG with CONSTANT_CASE version of the plugin slug (e.g. prefix for constants)
@ecotechie
Copy link

Name: Core Performance Tests

@Otto42
Copy link
Member

Otto42 commented Nov 23, 2021

Probably best to reflect somewhat on the test or experimental nature of it, because you probably don't want people installing it on sites that are meant to be 100% stable.

Perf-experiments, or something like that? I suck at naming, but something that reflects that it's for testing only.

@tillkruss
Copy link
Member

Performance Experiments was suggested in the Google doc as well. Maybe this perf-experiments for the wp.org slug?

@JustinyAhin
Copy link
Member

Probably best to reflect somewhat on the test or experimental nature of it, because you probably don't want people installing it on sites that are meant to be 100% stable.

We should also mention this in the repo README/docs. The experimental nature of the plugin, and the fact that it shouldn't be used as a permanent solution on sites.

@szepeviktor
Copy link
Contributor

szepeviktor commented Nov 24, 2021

There are two very-very separate parts of WordPress performance.

  1. WordPress core generating HTML code
  2. Browser loading HTML and linked resources, rendering page.

Please take this into consideration.

@ThierryA
Copy link
Member

ThierryA commented Nov 24, 2021

Just throwing some ideas, Performance Lab,Performance Labs, Perf Lab, Perf Labs.

While some modules will be for testing, it is also important to keep in mind that it should be developed in a reliable way and not only deployed on throw away sites (like any feature plugins would, and so is Gutenberg). For that reason it would be preferable not to over index on the experimental nature (IMO) which could lead to not getting the minimal user base adoption we are looking for.

@felixarntz felixarntz added Infrastructure Issues for the overall performance plugin infrastructure Needs Decision and removed help wanted labels Nov 24, 2021
@felixarntz
Copy link
Member Author

Performance Lab (slug performance-lab) would sound good to me. It still indicates that these are of somewhat experimental nature, but it sounds more catchy IMO. What do y'all think?

@ecotechie
Copy link

I'd like to see a more specific name, I still like my suggestion Core Performance Tests since that's what they are. Performance lab seems a bit broad.

@adamsilverstein
Copy link
Member

@ecotechie - I like the Core Performance part because it indicates this is a core based and targeted effort. I like Tests less because it would feel more risky for users to install.

How about Core Performance Lab?

@jdevalk
Copy link

jdevalk commented Nov 24, 2021

Core says nothing to "average" users, who should be installing this too. I like just Performance Lab too.

@tillkruss
Copy link
Member

I like Performance Lab as well, maybe with a short slug like perflab.

@aristath
Copy link
Member

+1 for Performance Lab (performace-lab)

@JustinyAhin
Copy link
Member

+1 for Performance Lab

@ThierryA ThierryA self-assigned this Nov 25, 2021
@ThierryA ThierryA mentioned this issue Nov 25, 2021
@ThierryA ThierryA linked a pull request Nov 25, 2021 that will close this issue
@jonoalderson
Copy link

+1 for Performance Lab (performace-lab)

@ecotechie
Copy link

ecotechie commented Nov 28, 2021

So we do expect/hope production sites install this plugin? And "average" users will install this on their live sites. I thought it was for testing purposes only. I then assume there will be a warning that it may break things?

@aristath
Copy link
Member

The concept of this plugin is similar to that of Gutenberg. So no, I don't think we should have warnings etc. All plugins "may break things", nothing is ever 100% feature-complete and bug-free.

@ecotechie
Copy link

Not trying to be a pain, but if this plugin is meant as a lab or for tests, it will break "things". Same with the Gutenberg plugin. I help maintain over 600 sites and if we ever see Gutenberg installed, we recommend removing it. Since it can be unstable and features can be removed. I know the nature of plugins is such that the code will sometimes cause unintended effects. However, a plugin dev that makes a well intentioned mistake and an essentially beta testing plugin are very different. I'll leave it at that and sorry to drag this out, but I feel users should be made aware when plugins are not meant for production sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.