Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding Standards: Use WordPress packages for coding standards - Step 1 #62

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

aaronjorbin
Copy link
Member

First pass at improving the formating and linting. Before a big fix, I wanted to get this agreed on and likely also get a few other PRs merged.

What?

The coding standards should be the same as elsewhere in the WordPress project.

Why?

Consistent styles make it easier for people to contribute.

Testing Instructions

Does it work?

First pass at improving the formating and linting. Before a big fix, I wanted to get this agreed on and likely also get a few other PRs merged.
Copy link

github-actions bot commented Feb 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props jorbin, desrosj.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>
Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@aaronjorbin
Copy link
Member Author

I'm planning to do this is three main chunks:

  1. Setup and agree on the configuration. (We are here now)
  2. Fix the formatting (Ideally as many PRs as possible are closed first so there is less conflict)
  3. Make sure linting is automated so it is enforced.

@desrosj desrosj merged commit a585694 into trunk Feb 8, 2024
6 checks passed
@desrosj desrosj deleted the coding-standards branch February 8, 2024 15:19
@desrosj desrosj changed the title Coding Standards: Use WordPress packages for coding standards Coding Standards: Use WordPress packages for coding standards - Step 1 Feb 8, 2024
@desrosj
Copy link
Contributor

desrosj commented Feb 8, 2024

Your plan sounds great to me. I think after #64 is merged we can proceed with steps 2 and 3. The other PRs remaining are experimental attempts at fixing an issue.

aaronjorbin added a commit that referenced this pull request Feb 8, 2024
Continues what was started in #62.

Only substance change is converting from `.map` to `.forEach` when there is no return.
@aaronjorbin aaronjorbin mentioned this pull request Feb 8, 2024
aaronjorbin added a commit that referenced this pull request Feb 8, 2024
Continues what was started in #62. This is step 2: Reformat everything and step 3: add an action. Lots of pinking shears were used here.

Only substance change is converting from `.map` to `.forEach` when there is no return.

Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>
Co-authored-by: desrosj <desrosj@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants