Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a prop format to be specified #64

Merged
merged 34 commits into from
Feb 8, 2024

Conversation

aaronjorbin
Copy link
Member

What?
This updates the action to allow a repository to configure the specific formats they want included in the bot's comments.

Why?
Often times, only one format is relavent to a given repo. This also helps make the comment shorter. Including both formats makes it quite long.

How?
Using the formats input, all, git, or svn can now be specified. The default is git.

Fixes #38, #47.
See: #61 and #63

Copy link

github-actions bot commented Feb 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj, jorbin, noisysocks, gziolo.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: aaronjorbin <jorbin@git.wordpress.org>
Co-authored-by: noisysocks <noisysocks@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor changes.

action.yml Outdated Show resolved Hide resolved
src/github.js Outdated Show resolved Hide resolved
@desrosj desrosj linked an issue Feb 6, 2024 that may be closed by this pull request
desrosj and others added 2 commits February 8, 2024 10:19
Co-authored-by: Jonathan Desrosiers <desrosj@users.noreply.github.com>
Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@aaronjorbin aaronjorbin merged commit 17e6f3f into trunk Feb 8, 2024
6 checks passed
@aaronjorbin aaronjorbin deleted the feature/allow-choice-of-format branch February 8, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only show the relevant props list Allow configuring the details included in the comment
2 participants