Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

fix spacing in query-loop and post-title size in single/post templates #191

Merged
merged 4 commits into from
Sep 26, 2022

Conversation

madhusudhand
Copy link
Member

@madhusudhand madhusudhand commented Sep 22, 2022

This change fixes

  • spacing around post title in homepage query loop.
  • adjusts the post-title to h4 in query loop
  • adjusts post title to h2 in single and post templates.
Before After
image image

Fixes: #190

@madhusudhand
Copy link
Member Author

adjusts the post-title to h4 in query loop

@mikachan By referring designs h4 is the right size, but this changes seems to reverse the change done in #111.
I might be missing the context, can you confirm if it was intentional?

@mikachan
Copy link
Member

By referring designs h4 is the right size, but this changes seems to reverse the change done in #111.

These titles were changed from h4 to h3 to maintain the correct heading hierarchy, as the 'Latest Posts' h3 heading was removed here.

We shouldn't really be changing the heading level just for styling reasons. Perhaps we need to reduce the font size of these headings via the query block settings instead?

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! The spacing change on the post title block looks good.

This PR has made me reconsider how we're using heading tags across the site. After looking at each template, I don't think we should be using a h1 for the site title in the header (it should just be a paragraph), and instead, ensure that each template has a contextual h1 (e.g. the query title on the archive page is a h1). What do you think?

templates/home.html Outdated Show resolved Hide resolved
@madhusudhand
Copy link
Member Author

I don't think we should be using a h1 for the site title in the header (it should just be a paragraph), and instead, ensure that each template has a contextual h1

I Agree. It isn't contextually right to use h1 for Site title, it can just be a paragraph and bold font to be given by its class, where as for H1, the archive page title gives the right context.

@madhusudhand madhusudhand changed the title fix spacing and title size in homepage query loop fix spacing and post-title size Sep 23, 2022
@madhusudhand madhusudhand changed the title fix spacing and post-title size fix spacing in query-loop and post-title size in single/post templates Sep 23, 2022
templates/page.html Outdated Show resolved Hide resolved
templates/single.html Outdated Show resolved Hide resolved
Co-authored-by: Sarah Norris <sarah@sekai.co.uk>
@carolinan
Copy link
Collaborator

1+ for only having one H1 on each page. The home page also needs an H1 though.

@madhusudhand madhusudhand reopened this Sep 26, 2022
@madhusudhand madhusudhand merged commit 4920c15 into trunk Sep 26, 2022
@madhusudhand madhusudhand deleted the fix/query-spacing branch September 26, 2022 06:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix spacing in Home template's query loop
3 participants