-
Notifications
You must be signed in to change notification settings - Fork 65
fix spacing in query-loop and post-title size in single/post templates #191
Conversation
These titles were changed from h4 to h3 to maintain the correct heading hierarchy, as the 'Latest Posts' h3 heading was removed here. We shouldn't really be changing the heading level just for styling reasons. Perhaps we need to reduce the font size of these headings via the query block settings instead? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! The spacing change on the post title block looks good.
This PR has made me reconsider how we're using heading tags across the site. After looking at each template, I don't think we should be using a h1 for the site title in the header (it should just be a paragraph), and instead, ensure that each template has a contextual h1 (e.g. the query title on the archive page is a h1). What do you think?
I Agree. It isn't contextually right to use h1 for Site title, it can just be a paragraph and bold font to be given by its class, where as for H1, the archive page title gives the right context. |
Co-authored-by: Sarah Norris <sarah@sekai.co.uk>
1+ for only having one H1 on each page. The home page also needs an H1 though. |
This change fixes
h4
in query looph2
in single and post templates.Fixes: #190