Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Variation Block out: fix font and color issues #196

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Conversation

madhusudhand
Copy link
Member

This fixes the following

Removing the color for h2 turns the heading in the homepage to contrast color which is expected. However, the design suggests the color to be primary which cannot be set in a variation.

Frontend:
image

Design:
image

Fixes: #192

@mikachan
Copy link
Member

Thanks for working on this!

Removing the color for h2 turns the heading in the homepage to contrast color which is expected. However, the design suggests the color to be primary which cannot be set in a variation.

This may be fixed if we change the main heading on the homepage to a h1, as we could set the colour of h1s to primary in the variation.

@madhusudhand
Copy link
Member Author

This may be fixed if we change the main heading on the homepage to a h1, as we could set the colour of h1s to primary in the variation.

fixed here a6a39b9

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@critterverse
Copy link
Collaborator

LGTM too, thank you!

@mikachan mikachan merged commit 6520757 into trunk Sep 23, 2022
@mikachan mikachan deleted the blockout/font-color branch September 23, 2022 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variation Block-out: font and color issues
3 participants