-
Notifications
You must be signed in to change notification settings - Fork 65
Block Out variation: Reduce XXL font size #261
Conversation
Adding top and bottom didn't seem to work for me either, it looks like it's being overridden by this selector: I managed to apply the spacing using padding instead. I've pushed up a version of this using the |
Opened an issue here for the margins: WordPress/gutenberg#44736 |
Thanks! |
@mikachan Would you be able to share a screenshot of the home template with these changes? I'm seeing the change to the Site Title but for some reason, am seeing the former size of the Post Titles before changes were made in #187. I'm sure it's just something wrong with my testing environment but just wanted to make sure the type scales work together nicely. |
Thanks @mikachan! Weird, what I was seeing in my testing env was correct but I think that we lost the reduction to the Post Title made in #187 somewhere along the way. That PR reduced the Post Title to "large" (so the Post Titles should look significantly smaller than the "Mindblown" typography that appears above and match the size of the navigation). Could we make that change again here? |
Ah, we removed the 'large' font size on Post Titles in #196, as it looks like the h2 font size was inheriting the same size, but now it's not. I've set the Post Titles back to 'large' again for this variation: I've done this by setting the font size on the h2s in the query loop, as otherwise the Post Titles in single posts are also set to 'large' as well. |
Looks great, thank you! |
This reduces the XXL font size preset in the Block Out variation by around 50%, as discussed here.
These are before/afters of the maximum size on my screen, at the same browser resolution:
Header:
Footer:
Closes #251.
cc. @kathrynwp