Skip to content
This repository has been archived by the owner on Oct 28, 2022. It is now read-only.

Block Out variation: Reduce XXL font size #261

Merged
merged 3 commits into from
Oct 7, 2022

Conversation

mikachan
Copy link
Member

@mikachan mikachan commented Oct 6, 2022

This reduces the XXL font size preset in the Block Out variation by around 50%, as discussed here.

These are before/afters of the maximum size on my screen, at the same browser resolution:

Header:

Before After
image image

Footer:

Before After
image image

Closes #251.

cc. @kathrynwp

@beafialho
Copy link
Collaborator

The size looks good to me.

One thing that could make the site title look better is some top and bottom margin to the site title block. I actually tried to set this up in my test site but could not see it on the front end.

Editor Front end
Captura de ecrã 2022-10-06, às 12 41 34 Captura de ecrã 2022-10-06, às 12 42 04

@mikachan
Copy link
Member Author

mikachan commented Oct 6, 2022

Adding top and bottom didn't seem to work for me either, it looks like it's being overridden by this selector: body .is-layout-flex > *. I'll see if there's an upstream issue for this.

I managed to apply the spacing using padding instead. I've pushed up a version of this using the var(--wp--preset--spacing--30) preset.

image

@mikachan
Copy link
Member Author

mikachan commented Oct 6, 2022

Opened an issue here for the margins: WordPress/gutenberg#44736

@beafialho
Copy link
Collaborator

Thanks!

@critterverse
Copy link
Collaborator

@mikachan Would you be able to share a screenshot of the home template with these changes? I'm seeing the change to the Site Title but for some reason, am seeing the former size of the Post Titles before changes were made in #187. I'm sure it's just something wrong with my testing environment but just wanted to make sure the type scales work together nicely.

@mikachan
Copy link
Member Author

mikachan commented Oct 6, 2022

Yes, sure! Here's the home template with these changes:

local-test-site local_

@critterverse
Copy link
Collaborator

Thanks @mikachan! Weird, what I was seeing in my testing env was correct but I think that we lost the reduction to the Post Title made in #187 somewhere along the way. That PR reduced the Post Title to "large" (so the Post Titles should look significantly smaller than the "Mindblown" typography that appears above and match the size of the navigation). Could we make that change again here?

@mikachan
Copy link
Member Author

mikachan commented Oct 7, 2022

Ah, we removed the 'large' font size on Post Titles in #196, as it looks like the h2 font size was inheriting the same size, but now it's not. I've set the Post Titles back to 'large' again for this variation:

local-test-site local_

I've done this by setting the font size on the h2s in the query loop, as otherwise the Post Titles in single posts are also set to 'large' as well.

@critterverse
Copy link
Collaborator

Looks great, thank you!

@mikachan mikachan merged commit d87443a into trunk Oct 7, 2022
@mikachan mikachan deleted the update/block-out-font-size branch October 7, 2022 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block out variation: Site title in footer too large
4 participants