Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Related Gutenberg Issues and PRs #75

Closed
10 of 23 tasks
jffng opened this issue Oct 8, 2021 · 11 comments
Closed
10 of 23 tasks

Related Gutenberg Issues and PRs #75

jffng opened this issue Oct 8, 2021 · 11 comments
Labels
[Type] Gutenberg An upstream bug or feature request in Gutenberg [Type] Overview

Comments

@jffng
Copy link
Collaborator

jffng commented Oct 8, 2021

Let's use this issue to track and prioritize issues that are needed for the theme.

Must have

Nice to have

Some of these are already associated to issues in this repo. It would be great to get more folks contributing to these issues.

@Mamaduka
Copy link
Member

The gutenberg#35551 issue is listed twice here.

@aristath
Copy link
Member

WordPress/gutenberg#35591 should also be added to the list above. We need the webfonts API in core & Gutenberg in order to properly implement it in the theme 👍

@tomjn
Copy link

tomjn commented Oct 28, 2021

is there an issue for i18n? I can't find anything for text localisation other than the patterns PR which is a short term workaround

@tomjn
Copy link

tomjn commented Oct 28, 2021

I've created WordPress/gutenberg#36061 to discuss text i18n as well as a general block i18n proposal

@carolinan
Copy link
Collaborator

Overlay menu can't be closed when "justify right" is used.
WordPress/gutenberg#36102

@jasmussen
Copy link

That overlay menu issue should be fixed by WordPress/gutenberg#36105.

@kjellr kjellr changed the title Gutenberg Issues and PRs needed Related Gutenberg Issues and PRs Nov 1, 2021
@carolinan
Copy link
Collaborator

Post title overflow: WordPress/gutenberg#35703

@ndiego
Copy link
Member

ndiego commented Nov 7, 2021

I would like to propose that WordPress/gutenberg#35267 gets bumped to Must Have. The title of the ticket is a bit too simplistic, this issue actually nullifies any margin settings set in theme.json if blockGap is enabled. It's because the following CSS is so specific. While it may not be impacting the theme currently, it will once the public starts "playing" with it.

image

@kjellr
Copy link
Collaborator

kjellr commented Nov 8, 2021

The title of the ticket is a bit too simplistic, this issue actually nullifies any margin settings set in theme.json if blockGap is enabled.

Would you mind sharing this feedback in that ticket? The way we get around this in the theme currently is just by specifying a blockGap that is generally compatible with paragraph blocks. But there are a few minor circumstances where that smaller blockGap isn't actually ideal.

I'm not 100% certain about it being a must-have (for this theme at least), but since this is overwriting margin values, I think it's very reasonably a bugfix that should make it into 5.9.

@ndiego
Copy link
Member

ndiego commented Nov 8, 2021

Would you mind sharing this feedback in that ticket? The way we get around this in the theme currently is just by specifying a blockGap that is generally compatible with paragraph blocks. But there are a few minor circumstances where that smaller blockGap isn't actually ideal.

For sure!

@kjellr kjellr removed this from the Feature Freeze milestone Nov 12, 2021
@jffng
Copy link
Collaborator Author

jffng commented Jan 24, 2022

Closing this now that the theme is added in 5.9.

@jffng jffng closed this as completed Jan 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Gutenberg An upstream bug or feature request in Gutenberg [Type] Overview
Projects
None yet
Development

No branches or pull requests

8 participants