Navigation: Fix justifications #36105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
This was referenced Nov 1, 2021
|
Size Change: +19 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
|
With this PR, the justification only shows in the overlay. Not in the editor, and not on the front when the overlay is closed. |
|
Ack, I could swear that worked fine in my testing? Taking a second look, and thank you for testing. That would explain the initial rules. |
|
🤔 I'm maybe missing something, but everything seems to be working for me. Here's my editor: Here's my frontend:
Can you provide more specific steps to reproduce? |
|
Which editor? |
jasmussen
force-pushed
the
fix/navigation-justifid-close
branch
from
1badf24 to
e8b6ea4
Compare
|
I just rebased to fix up an icon bugfix.
I'm seeing the same behavior in the post editor, and the site editor, testing using latest trunk version of TwentyTwentyTwo:
|
|
I have cleared cache. Chrome, Windows. TT2. Nav with page list, site editor, nav block is not selected: Short, mixed items, site editor: Long menu, posts only, site editor: |
|
In the overlay, should the submenu items be indented to the left that way? |
|
This is odd. In the first screenshots on my list, the editor is not displaying the page called "A blog page", but the front is. |
|
Oh! It's the new Page List that's broken. I'll take a look.
CC @noisysocks just in case, I'm not sure why the new page list would show a page on the front but not the editor. I haven't yet reproduced myself, but in case it can connect any dots. |
|
Okay, thanks for your patience, I think I fixed it now.
Well, yes, but I'd be happy to try and push changes here if we have a good idea (though I'd like to do that separately since it's an existing issue). The thing is, if you have nested submenus, they are forcefully unfolded in the overlay menu, and so we need a way to indicate the blocks are nested blocks. |
Maybe something to do with the post status? If you can figure out some minimal steps to reproduce or what the missing posts have in common then please create an issue 😄 |
|
Thank you! |
7 tasks
andrewserong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #36102, and WordPress/twentytwentytwo#75
Justifications were recently polished (I think in #35077), and it appears the wrong rules were applied for the content inside the burger menu — justify-content instead of align-items. This PR fixes it, and in my testing, fixes the issue:
How has this been tested?
I don't know whether those rules were intentionally so, or whether it was a mistake, so it'd be good to test the various justifications, both with and without the "always-burger".
It seems to have been a mistake to me.
I'm unable to provide testing content, because the navigation block now saves menus separately. Please insert navigation menus with lots of content, and with little content, and justify it left, right, center, and try with and without the burger options. Justificiations including the inherited justification inside the burger modal, should all look right.
Checklist:
*.native.jsfiles for terms that need renaming or removal).