Fix block registration from metadata #3501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
commented
Oct 20, 2022
aristath
force-pushed
the
fix/block-registration
branch
from
99e2cbe
to
d2f4977
Compare
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
…ix/block-registration
|
Added PHPUnit tests and fixed issues that surfaced from said tests. |
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
costdev
reviewed
Mar 3, 2023
Co-authored-by: Colin Stewart <79332690+costdev@users.noreply.github.com>
…ix/block-registration
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
spacedmonkey
requested changes
Jul 10, 2023
There was a problem hiding this comment.
Please consider 0bfc842. This change will revert this change.
Can you please elaborate? How does it revert that change? I don't see it 🤔 |
In 0bfc842, I made it so the file_exists is not run on the core blocks. The file exists is pointless as it always exists and ends up I/O. In this PR, you move the file_exists out the if statement, make it run again always, reverting my change. |
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
|
@aristath Is this good to commit. |
|
Yes, it is. 👍 |
|
Thanks for the PR! Merged in r57026. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/56865
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.