Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Sync Gutenberg Packages for WordPress 6.5 RC 1 #6218

Closed

Conversation

youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Mar 4, 2024

Sync Gutenberg to WP Core for WordPress 6.5 RC 1. Based on this PR in the Gutenberg repo:

Trac ticket: https://core.trac.wordpress.org/ticket/60315
Trac ticket: https://core.trac.wordpress.org/ticket/60665

@youknowriad youknowriad self-assigned this Mar 4, 2024
Copy link

github-actions bot commented Mar 4, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props youknowriad, talldanwp, get_dave.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and few features from the included PRs and they seem ok.

However, I looked on the front of the site and saw this error:

Fatal error: Uncaught Error: Call to undefined function wp_interactivity_data_wp_context() in /var/www/html/wp-includes/blocks/navigation.php:555

Copy link

github-actions bot commented Mar 4, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@youknowriad
Copy link
Contributor Author

@getdave yes, the patch for that one is ready to. @swissspidy is just waiting for the current package update to land first.

Copy link

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the basis that patch for wp_interactivity_data_wp_context will be applied post-sync

@youknowriad
Copy link
Contributor Author

@youknowriad youknowriad closed this Mar 4, 2024
@youknowriad youknowriad deleted the update/packages-6.5-rc1 branch March 4, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants