php-cli: Don't pass the TMPDIR variable to NodePHP.load #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## The problem * `npm` scripts set the TMPDIR env variable * PHP accepts a TMPDIR env variable and expects it to be a writable directory within the PHP filesystem. These two clash and prevent PHP from creating temporary files and directories so this PR prevents exposing the npm-set `TMPDIR` env variable to PHP. Closes #828 ## Testing instructions Run the following PHP script with and without this PR: ```php <?php var_dump(sys_get_temp_dir()); var_dump(tmpfile()); ``` Run it as follows: ``` nx reset; PHP=8.2 nx start php-wasm-cli ``` Without this PR, it should print something like this: ``` string(48) "/var/folders/sb/cywb762129g3f0jzq1_p2q5h0000gp/T" bool(false) ``` With this PR, it should print this: ``` string(4) "/tmp" resource(4) of type (stream) ```
adamziel
added
[Type] Bug
adamziel
added a commit
that referenced
this pull request
Jan 17, 2024
A change that was missing from #953
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
npmscripts set the TMPDIR env variableThese two clash and prevent PHP from creating temporary files and directories so this PR prevents exposing the npm-set
TMPDIRenv variable to PHP.Closes #828
Testing instructions
Run the following PHP script with and without this PR:
Run it as follows:
Without this PR, it should print something like this:
With this PR, it should print this: