Skip to content

php-cli: Don't pass the TMPDIR variable to NodePHP.load #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2024
Merged

php-cli: Don't pass the TMPDIR variable to NodePHP.load #953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/php-wasm/cli/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,16 @@ async function run() {
if (!SupportedPHPVersionsList.includes(phpVersion)) {
throw new Error(`Unsupported PHP version ${phpVersion}`);
}


// npm scripts set the TMPDIR env variable
// PHP accepts a TMPDIR env variable and expects it to
// be a writable directory within the PHP filesystem.
// These two clash and prevent PHP from creating temporary
// files and directories so let's just not pass the npm TMPDIR
// to PHP.
// @see https://github.com/npm/npm/issues/4531
// eslint-disable-next-line @typescript-eslint/no-unused-vars
const { TMPDIR, ...envVariables } = process.env;
const php = await NodePHP.load(phpVersion, {
emscriptenOptions: {
ENV: {
Expand Down