Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the consistency of <title>s #399

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

renintw
Copy link
Contributor

@renintw renintw commented Nov 21, 2023

Fixes #366

This PR improves consistency for page <title>. (copies are referred to showcase)

I didn't add WordPress Developer Resources because it kind of makes the title too long and a bit similar to Developers.WordPress.org at the end. But actually I don't feel strong not adding it, though.

Screenshots

Homepage Screenshot 2023-11-22 at 6 04 58 AM
CPT Screenshot 2023-11-22 at 6 05 09 AM
CPT Screenshot 2023-11-22 at 6 05 29 AM
CPT Screenshot 2023-11-22 at 6 05 47 AM
CPT Screenshot 2023-11-22 at 6 05 56 AM
CLI Commands Screenshot 2023-11-22 at 6 37 56 AM
Archive Page Number Screenshot 2023-11-22 at 6 43 36 AM
Handbook Screenshot 2023-11-22 at 7 11 15 AM
Handbook Screenshot 2023-11-22 at 7 11 27 AM
Handbook Screenshot 2023-11-22 at 7 12 00 AM
Handbook Screenshot 2023-11-22 at 7 12 08 AM
Handbook Screenshot 2023-11-22 at 7 12 57 AM
Handbook Screenshot 2023-11-22 at 7 13 06 AM
Handbook Screenshot 2023-11-22 at 7 13 24 AM
Handbook Screenshot 2023-11-22 at 7 13 40 AM
Singe Page Screenshot 2023-11-22 at 7 14 33 AM
Singe Page Screenshot 2023-11-22 at 7 14 46 AM

@renintw renintw self-assigned this Nov 21, 2023
@renintw renintw added this to the MVP milestone Nov 21, 2023
Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Checked search pages too, all good 👍

@renintw renintw merged commit da35dfe into trunk Nov 21, 2023
1 check passed
@renintw renintw deleted the enhance/Improve-the-consistency-of-page-titles branch November 21, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Titles are too verbose
2 participants