Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the consistency of <title>s #399

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Improve the consistency of <title>s #399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 29 additions & 34 deletions source/wp-content/themes/wporg-developer-2023/inc/head.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,54 +33,49 @@ public static function do_init() {
* @return array The document title parts.
*/
public static function document_title( $parts ) {
global $page, $paged;
global $wp_query;

if ( is_feed() ) {
$parts['site'] = __( 'Developer.WordPress.org', 'wporg' );
$post_type = get_query_var( 'post_type' );
$sep = '–';

if ( is_front_page() || is_feed() ) {
$parts['title'] = 'WordPress Developer Resources';
return $parts;
}

$title = $parts['title'];
$sep = '|';

$post_type = get_query_var( 'post_type' );

// Omit 'Home' from the home page.
if ( 'Home' === $title ) {
$title = '';
}
// Add post type to title if it's a parsed item.
elseif ( is_singular() && \DevHub\is_parsed_post_type( $post_type ) ) {
if ( $post_type_object = get_post_type_object( $post_type ) ) {
$title .= " $sep " . get_post_type_object( $post_type )->labels->singular_name;
if ( is_singular() && ( \DevHub\is_parsed_post_type( $post_type ) ) ) {
// Add post type to title if it's a parsed item.
if ( get_post_type_object( $post_type ) ) {
$parts['title'] .= " $sep " . get_post_type_object( $post_type )->labels->singular_name;
}
}
// Add handbook name to title if relevent
elseif ( ( is_singular() || is_post_type_archive() ) && false !== strpos( $post_type, 'handbook' ) ) {
if ( $post_type_object = get_post_type_object( $post_type ) ) {
} elseif ( ( is_singular() || is_post_type_archive() ) && false !== strpos( $post_type, 'handbook' ) ) {
// Add handbook name to title if relevant.
if ( get_post_type_object( $post_type ) ) {
$handbook_label = get_post_type_object( $post_type )->labels->name;
$handbook_name = \WPorg_Handbook::get_name( $post_type ) . " Handbook";

// Replace title with handbook name if this is landing page for the handbook
if ( $title == $handbook_label ) {
$title = $handbook_name;
// Otherwise, append the handbook name
// Replace title with handbook_label(CPT name) if they have too many repeated words. Otherwise, append the handbook_label.
if ( strpos( $parts['title'], $handbook_label ) !== false ) {
$parts['title'] = $handbook_label;
} else {
$title .= " $sep " . $handbook_name;
$parts['title'] .= " $sep " . $handbook_label;
}
}
}
// Add "WP-CLI Command" to individual CLI command pages.
elseif ( is_singular( 'command' ) ) {
$title .= " $sep WP-CLI Command";
} elseif ( is_singular( 'command' ) ) {
// Add "WP-CLI Command" to individual CLI command pages.
$parts['title'] .= " $sep WP-CLI Command";
}

// Add a page number if necessary:
if ( isset( $parts['page'] ) && $parts['page'] >= 2 ) {
$title .= " $sep " . sprintf( __( 'Page %s', 'wporg' ), $parts['page'] );
// If results are paged and the max number of pages is known.
if ( is_paged() && $wp_query->max_num_pages ) {
$parts['page'] = sprintf(
// translators: 1: current page number, 2: total number of pages
__( 'Page %1$s of %2$s', 'wporg' ),
get_query_var( 'paged' ),
$wp_query->max_num_pages
);
}

$parts['title'] = $title;

return $parts;
}

Expand Down
Loading