Fix the position of the Table of Contents #97
Conversation
| "settings": { | ||
| "custom": { | ||
| "alignment": { | ||
| "aligned-max-width": "100%" | ||
| } | ||
| }, | ||
| "layout": { | ||
| "contentSize": "960px" | ||
| } | ||
| }, |
There was a problem hiding this comment.
| <div class="wp-block-group alignfull" style="padding-right:var(--wp--preset--spacing--edge-space);padding-left:var(--wp--preset--spacing--edge-space)"> | ||
|
|
||
| <!-- wp:group {"align":"left","className":"has-three-columns","layout":{"type":"flex","flexWrap":"wrap","orientation":"vertical"}} --> | ||
| <div class="wp-block-group alignleft has-three-columns"> |
There was a problem hiding this comment.
3 column layout wrapper added
source/wp-content/themes/wporg-documentation-2022/templates/page-topic-landing.html
Outdated
Show resolved
Hide resolved
source/wp-content/themes/wporg-documentation-2022/parts/search.html
Outdated
Show resolved
Hide resolved
| "settings": { | ||
| "custom": { | ||
| "alignment": { | ||
| "aligned-max-width": "100%" |
There was a problem hiding this comment.
Do we use this value anywhere? IIRC it's leftover from the long-past (news theme), but i don't recall if we started using it again in devhub
There was a problem hiding this comment.
Not that I know of. We keep needing to override it. I'll test removing it in my sandbox.
There was a problem hiding this comment.
It's used here, but removing this doesn't seem to affect any of the sites I've tested. It is being overridden in all the sites I've worked on (Dev Res, Docs and Learn), so I think it can be safely removed. I think not in this PR though.
There was a problem hiding this comment.
Created an issue
There was a problem hiding this comment.
I think not in this PR though.
Why add it now just to remove it later?
There was a problem hiding this comment.
Fair point 😁 It's just that I've already got 4 PRs to merge for this one fix, and I feel like it needs more testing.
There was a problem hiding this comment.
I've put in in progress on the Learn board, I will continue with it
adamwoodnz
force-pushed
the
enhance/theme
branch
from
94ca533 to
174bf81
Compare
adamwoodnz
force-pushed
the
enhance/theme
branch
from
174bf81 to
61013c1
Compare
This PR updates the single page template to use the 3 column layout from the parent theme. This brings alignment with the single pages on Developer Resources, and fixes the incorrect positioning resulting from WordPress/gutenberg#60347. In implementing this layout I've also updated the post title text styles, and moved the search bar to the new position shown in the designs.
Depends on WordPress/wporg-mu-plugins#624 and WordPress/wporg-parent-2021#140
Closes #96
Closes #95
Screenshots
Desktop
How to test the changes in this Pull Request: