Maintain sidebar container compatibility with 3 column layout #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parent theme 3 column layout has been updated for compatibility with Gutenberg 18.5. This change makes the scrollbar container compatible. The logic is simplified so that the padding and margin aren't factors. See WordPress/wporg-parent-2021#139
adamwoodnz
force-pushed
the
fix/sidebar-container-gutenberg-18-5-compat
branch
from
2d01faa to
4b3982a
Compare
adamwoodnz
changed the title
ryelle
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent theme 3 column layout has been updated for compatibility with Gutenberg 18.5.
This change makes the scrollbar container compatible. The logic is simplified so that the padding and margin aren't factors.
See WordPress/wporg-parent-2021#139
Test using WordPress/wporg-documentation-2022#97 and WordPress/wporg-developer#522