Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table of contents sidebar is too far down the page #139

Closed
ryelle opened this issue Jun 7, 2024 · 3 comments
Closed

Table of contents sidebar is too far down the page #139

ryelle opened this issue Jun 7, 2024 · 3 comments
Assignees
@adamwoodnz
Labels
[Type] Bug Something isn't working

Comments

@ryelle
Copy link
Contributor

ryelle commented Jun 7, 2024

When scrolled to the top of the page, the table of contents sidebar is too far offset.

Screen Shot 2024-06-07 at 17 00 25

This seems to be new with the Gutenberg update, because constrained blocks now get position:relative https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/group/style.scss#L6

I'm not sure if we should unset the position:relative or adjust the top spacing on the sidebar.
@ryelle ryelle added the [Type] Bug Something isn't working label Jun 7, 2024
@adamwoodnz adamwoodnz self-assigned this Jun 9, 2024
@adamwoodnz adamwoodnz transferred this issue from WordPress/wporg-developer Jun 10, 2024
@adamwoodnz adamwoodnz transferred this issue from WordPress/wporg-mu-plugins Jun 10, 2024
@adamwoodnz
Copy link
Contributor

This seems to be new with the Gutenberg update, because constrained blocks now get position:relative https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/group/style.scss#L6

I'm not sure if we should unset the position:relative or adjust the top spacing on the sidebar.

Agreed that this is the root cause. Transferring this to Parent where I think we should set the .has-three-columns class to position: relative so that we have more control over the layout from that parent node. This will require changes in the sidebar container block too, and possibly changes in the consuming themes.

adamwoodnz added a commit to WordPress/wporg-mu-plugins that referenced this issue Jun 10, 2024
@adamwoodnz
Update container fixed positioning
2d01faa 
The parent theme 3 column layout has been updated for compatibility with Gutenberg 18.5.
This change makes the scrollbar container compatible.
The logic is simplified so that the padding and margin aren't factors.

See WordPress/wporg-parent-2021#139
@adamwoodnz adamwoodnz mentioned this issue Jun 10, 2024
Merged
adamwoodnz added a commit to WordPress/wporg-mu-plugins that referenced this issue Jun 10, 2024
@adamwoodnz
Update container fixed positioning
4b3982a 
The parent theme 3 column layout has been updated for compatibility with Gutenberg 18.5.
This change makes the scrollbar container compatible.
The logic is simplified so that the padding and margin aren't factors.

See WordPress/wporg-parent-2021#139
adamwoodnz added a commit that referenced this issue Jun 10, 2024
@adamwoodnz
Create positioning context for 3 column layout
98a8bcb 
Gutenberg 18.5 added position:relative to all constrained blocks, breaking the 3 column layout.
This change adds makes the layout less brittle by defining it's own positioning context, and adjusts position of the children accordingly.

See #139
@adamwoodnz adamwoodnz mentioned this issue Jun 10, 2024
Merged
adamwoodnz added a commit to WordPress/wporg-developer that referenced this issue Jun 10, 2024
@adamwoodnz
Fix 3 column layout for compatibility with Gutenberg 18.5
fa80dc4 
See WordPress/wporg-parent-2021#139
@adamwoodnz adamwoodnz mentioned this issue Jun 10, 2024
Merged
adamwoodnz added a commit that referenced this issue Jun 11, 2024
@adamwoodnz
Create positioning context for 3 column layout (#140)
510f60c 
Gutenberg 18.5 added position:relative to all constrained blocks, breaking the 3 column layout.
This change adds makes the layout less brittle by defining it's own positioning context, and adjusts position of the children accordingly.

See #139
adamwoodnz added a commit to WordPress/wporg-mu-plugins that referenced this issue Jun 11, 2024
@adamwoodnz
Update container fixed positioning (#624)
3a86032 
The parent theme 3 column layout has been updated for compatibility with Gutenberg 18.5.
This change makes the scrollbar container compatible.
The logic is simplified so that the padding and margin aren't factors.

See WordPress/wporg-parent-2021#139
adamwoodnz added a commit to WordPress/wporg-developer that referenced this issue Jun 11, 2024
@adamwoodnz
Fix the position of the Table of Contents (#522)
4d5a178 
Fix 3 column layout for compatibility with Gutenberg 18.5

See WordPress/wporg-parent-2021#139
@ryelle
Copy link
Contributor Author

ryelle commented Jun 12, 2024

@adamwoodnz Is there anything else to wrap up for this issue?

@adamwoodnz
Copy link
Contributor

Nope, we're done!

@github-project-automation github-project-automation bot moved this from In Progress to Done in @adamwoodnz's WIP Jun 12, 2024
DanyloKubyshkin pushed a commit to DanyloKubyshkin/wordpress-org that referenced this issue Jul 12, 2024
@adamwoodnz
Create positioning context for 3 column layout (#140)
927816b 
Gutenberg 18.5 added position:relative to all constrained blocks, breaking the 3 column layout.
This change adds makes the layout less brittle by defining it's own positioning context, and adjusts position of the children accordingly.

See WordPress/wporg-parent-2021#139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamwoodnz adamwoodnz

Labels
[Type] Bug Something isn't working
Projects
@adamwoodnz's WIP
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ryelle @adamwoodnz