chore: Update prerelease/v4 with latest master #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(badge): Add CountBadge component Co-authored-by: Lynn Chyi <14299381+lychyi@users.noreply.github.com> Co-authored-by: Alex Nicholls <anicholls3@gmail.com>
…rkday#651) * fix(checkbox): Add explicit positioning to ripple * fix(radio): Add explicit positioning to ripple * fix(radio): Change ripple to span * fix(checkbox): Change ripple to span * fix(radio): Align focus hover state with Checkbox * fix: Remove extraneous style from ripples * chore: Add comment, re: using pointer-events: none
If the container of a Switch specifies text-align: center, the fact that the input (click target) is inline-block will shift inline based on the text alignment. Setting it to display: block keeps it where it needs to be since it's now a block level element.
* chore: Add public config to create-component script * fix: Review update * fix: Review update
* chore: Release v3.8.0 Co-authored-by: Alex Nicholls <anicholls3@gmail.com>
* fix(select): Sync button animation on menu blur * fix(select): Fix focus when clicking button to dismiss the menu * fix(select): Modify selection to trigger on click instead of mouseDown * test(select): Fix unit test * fix(select): Prevent options from inheriting text alignment
* test(select): Add missing visual states for selected options * test(select): Add missing visual states for assistive-focused options * test(select): Adjust width of visual state options * test(select): Remove inline styles on components * test(select): Break options table apart based on error state * test(select): Separate tables further based on disabled state * test(select): Remove old options table * test(select): Remove unnecessary Alert and Error tables * test(select): Adjust options width to a less arbitrary value
* test: Add helper to enable chromatic snapshots * test(button): Refactor visual testing stories to use CSF * test(form-field): Refactor visual testing stories to use CSF * test(pagination): Refactor visual testing stories to use CSF * test(select): Refactor visual testing stories to use CSF * test(popup): Refactor visual testing stories to use CSF * test(toast): Refactor visual testing stories to use CSF * test(form-field): Rename testing stories into their own section * test(button): Rename testing stories into their own section * test: Rename remainder of testing stories into their own section * fix(form-field): Fix import * refactor: Add category to create-component script and use CSF * feat: Add CSF visual testing story to create-component script * fix(form-field): Remove unused variable * fix(form-field): Properly export theme stories * refactor: Use a decorator for enabling snapshots * feat: Add override to withSnapshotsEnabled so it can be used per story
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
anicholls
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
anicholls
changed the title
|
So far my commit matches my changes 👍 |
|
My changes look good, too 👍. @anicholls Should I approve the new Chromatic baselines for Select as well? |
|
@anicholls My changes from #651 look good here. |
alanbsmith
reviewed
Jun 3, 2020
NicholasBoll
approved these changes
Jun 4, 2020
chore(button): Capitalize visual testing story filenames test(button): Move theming visual testing to separate CSF files test(button): Add CSF visual tests for ToolbarIconButton chore(button): Remove old visual testing file test(button): Add CSF story files for new button components test(button): Make common state table columnProps reusable fix(form-field): Fix text input visual testing story categorization fix(button): Calculate permutateProps to avoid storysource addon issue chore(select): Fix comments lost in merge test(select): Add CSF visual tests for theming fix(button): Fix categorization for icon button testing story fix(button): Fix empty rows on toolbar icon button stories test(button): Fix story organization for visual testing stories chore: Add linting changes that somehow didn't get committed chore(button): Remove hyperlink theming story since it can't be themed fix(button): Fix text button visual testing stories fix(radio): Fix radio group selection on visual testing story
anicholls
force-pushed
the
update-prerelease
branch
from
4bf6a26 to
35e0c77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also included some fixes and additions to bring things up to par in 35e0c77