feat: Add toolbar dropdown button #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mannycarrera4
commented
May 28, 2020
mannycarrera4
commented
May 28, 2020
mannycarrera4
commented
May 28, 2020
mannycarrera4
commented
May 28, 2020
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
mannycarrera4
commented
May 29, 2020
anicholls
reviewed
Jun 2, 2020
| background: 'transparent', | ||
| }, | ||
| hover: { | ||
| icon: colors.licorice500, |
There was a problem hiding this comment.
Active and hover are using the same color (same goes for ToolbarIconButton actually). Is this intended?
There was a problem hiding this comment.
it's per design! i Will double confirm to make sure this is the intended styles
anicholls
reviewed
Jun 3, 2020
modules/button/react/stories/visual-testing/stories_ToolbarDropdownButton.tsx
Outdated
Show resolved
Hide resolved
modules/button/react/stories/visual-testing/stories_ToolbarIconButton.tsx
Outdated
Show resolved
Hide resolved
modules/button/react/stories/visual-testing/theming/stories_ToolbarIconButton.tsx
Outdated
Show resolved
Hide resolved
modules/button/react/stories/visual-testing/theming/stories_ToolbarDropdownButton.tsx
Outdated
Show resolved
Hide resolved
anicholls
added
blocked
…olbarDropdownButton.tsx Co-authored-by: Alex Nicholls <anicholls3@gmail.com>
…olbarIconButton.tsx Co-authored-by: Alex Nicholls <anicholls3@gmail.com>
mc-add-dropdown-icon-button
anicholls
approved these changes
Jun 5, 2020
This was referenced Jun 12, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #685
Add toolbar dropdown button
Blocked on #688