chore: Release v4.0.0 #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ci: Make canary preid and dist tag configurable * ci: Run canary publish for prerelease branches * ci: Move branch logic into canary script * ci: Update trunk matching rule
* ci: Account for variable preid in canary script regex * ci: Use major version for canary build if on a prerelease branch * ci: Fix boolean condition order of operations
…rkday#471) * refactor: Add initial thoughts on button refactor * refactor: Avoid duplicating size types * refactor(button): Refactor to new structure for styles * refactor(button): Add missing growth behavior * fix(button): Fix text button variant * refactor(button): Use labs styled function * refactor(button): Add remainder of package files * refactor(button): Add stories for new button components * refactor(button): Initial pass at refactoring IconButton * refactor(button): Remove the need for extra span in IconButton * refactor(button): Fix text button styling and simplify label styles * refactor(button): Move spacing logic from parts to ButtonContainer * refactor(button): Remove unnecessary/redundant color specs * refactor(button): Fix deprecated button colors * refactor(button): Add deprecation message to deprecated button * refactor(button): Add callback for icon button onToggleChange * refactor(button): Account for toggled icon button icon fills * refactor(button): Implement configurable focus ring * refactor(button): Add missing growth behavior * refactor(button): Remove icon button backgrounds that shouldn't be there * refactor(button): Remove unnecessary styles * refactor(button): Inline default props * refactor(button): Standardize color object API in preps for theming * Revert "refactor(button): Inline default props" This inline method is not picked up as default props in TS This reverts commit f66b4b1f97cb84d1d15189f231d47d4962f3555f. * fix: Resolve build errors * fix(labs): Add missing dependency * fix(labs): Use correct ref props * fix(labs): Only call IconButton::onToggleChange on update * test(labs): Add testing-library/react tests for new button * fix(labs): Resolve storybook console errors * ci(labs): Enable chromatic snapshots for new buttons * refactor(button): Change base interface back to ButtonHTMLAttributes * chore: Disable no-use-before-define for functions * refactor(button): Clean up spacing/size usage in ButtonLabelIcon * fix(button): Ensure IconButton onToggleChange doesn't become stale * docs(button): Fix typo in TextButton comment * refactor(button): Change size enums to string literals * refactor(button): Use new default prop style * docs(button): Update readme * refactor(button): Replace old button module with refactored button * refactor(button): Re-add old stories * fix(button): Fix a few issues with deprecated_Button * fix(button): Use correct sizes for delete button story * refactor(button): Remove data label support from HighlightButton * refactor(button): Remove unnecessary fn components from visual testing * refactor(button): Convert text button allCaps into a prop * refactor(button): Split outline button variants into their own component * refactor(button): Don't show data label or icon at small sizes * refactor(button): Use const instead of enum for ButtonSize * test(button): Update story in failing cypress test * fix(button): Fix button label icon alignment * fix(modal): Update old delete button references in modal stories * fix(pagination): Fix pagination buttons after button refactor
* fix(button): Fix type errors in IconButton stories * fix(button): Fix incorrect package.json fields * fix(button): Add missing default export * docs(button): Fix button css readme * fix(popup): Fix popup after button refactor * fix: Use css buttons for popup and modal css stories * fix(toast): Fix toast icon size after button refactor * refactor(pagination): Use correct font size & weight after refactor
…orkday#505) * refactor(button): First pass at breaking IconButtonToggleGroup out * feat(labs): Document SegmentedControl * fix(labs): Fix dependency versions after rebase * feat(labs): Remove isRTL prop since we now use contexts for this * test(labs): Move IconButtonToggleGroup tests to new component * chore(button): Remove old IconButtonToggleGroup * fix(labs): Fix border jumping in SegmentedControl * feat(labs): Use state hook instead of wrapper for SegmentedControl story * feat(labs): Add disabled button for snapshot testing * chore(segmented-control): Fix dependencies * chore(button): Fix weird duplicate story file issue * test(segmented-control): Convert tests to testing-library/react * fix(segmented-control): Misc. story fixes * chore(segmented-control): Update versions
* fix(modal): Hide background content from assistive technology Modal now uses a portal for content to not be constrained by a parent container. This also allows for the hiding of non-modal content (visibly covered by modal overlay) to assistive technology. Fixes Workday#414 Fixes Workday#330 Co-authored-by: Manuel Carrera <manuel.carrera.91@gmail.com>
* feat(button): Add theming to ButtonContainer and standard Button * refactor(button): Refactor stories to prep for theming * refactor: Use correct color for default theme error palette light * feat(button): Add theming support to DeleteButton * feat(button): Add theming to DropdownButton * feat(button): Add theming support to HighlightButton * refactor(button): Don't show theming story for deprecated_Button * feat(button): Add theming to IconButton * feat(button): Add theming to OutlineButton * feat(button): Add theming support to TextButton * fix: Revert optionality change to Themeable interface * fix(button): Use darker color for disabled text buttons
* chore: Upgrade babel and typescript * chore: Remove unused babel deps * fix(core): Remove support for old browsers from InputProvider Due to TS errors * fix: Remove dependencies on material-ui popper due to TS error * chore: Revert babel updates for now * chore: Remove unused react-test-renderer * chore: Upgrade react and react-dom to 16.12.0 * feat: Use downlevel-dts to publish types from TS 3.5 * chore: Remove tslint dependencies * chore: Adjust for slightly different lint rules * chore: Remove react-scripts(CRA) dep * fix(menu): Check for both null and undefined child * ci: Don't run kill jobs in parallel (preventing false positive builds) * build: Add postcss back into storybook webpack config * fix: Revert storybook webpack config for now * fix(color-picker): Fix check lost in rebase
* docs: Add WIP v4.0 migration guide * docs: Add changelog entry for 4.0.0-beta.0 * chore: Bump modules to v4.0.0-beta.0 * docs: Add latest PR to changelog
* fix(button): Add new hover background styles to text buttons * feat(button): Use 2px underline for text buttons * fix(button): Remove unused import * fix(button): Force negative margin for button label icons * fix(button): Add some missing styles for TextButton
* refactor(core): Change link type variant styles * feat(button): Add hyperlink component * docs(button): Add Hyperlink to button readme * feat(button): Add inverse variant to Hyperlink * fix(button): Use soap200 for hyperlink active bg * refactor(core): Update hyperlink style in css type mixins
* docs: Update Component Status (Workday#547) Added new components and taxonomy changes. * fix(checkbox): Remove synthetic typing in checkbox onchange * fix: Explicitly typing for JSDoc * fix: Convert all spots with onChange * fix: Radio Group onRadioChange typing * fix: Deprecate SyntheticEvent type Co-authored-by: Justin Panté <1861673+jpante@users.noreply.github.com> Co-authored-by: Donovan Gini <donovan.gini@workday.com> Co-authored-by: Alan Smith <a.bax.smith@gmail.com>
* chore: Destructure default props * chore: Destructure props for modal * fix: Make props optional in modal content * fix: Update optional prop for combobox * fix: Update default props for drawer and combo * fix: Update aria label prop name * fix: Destructure props for drawer header * fix: Destructure search box default props * fix: Destructure props for header * fix: Destructure default props for menu item * fix: Destructure default props for menu item and pagination * fix: Destructure default props for menu avatar banner * fix: Destructure props for avatar button card checkbox colorinput * fix: Destructure textbutton popper cookie banner fomfield hint label * fix: Destructure props for radio radigroup select * fix: Destructure for page header layout * fix: Destructure selec option sidepanel skeleton status * fix: Destructure button switch text area text input toast tooltip * fix: Destructure props for different buttons and popper * fix: Update readme and component props * fix: Update menu test and default prop for card * fix: Update icons props * test: Update classname prop for svg * test: Revert files with failing tests * fix: Add padding as optional for card * fix: Revert tooltip changes * fix: Update default props for pagination * fix: Fix default props for system icons * fix: Destrcutrue props for menuitem * fix: Add todo for menuitem * fix: Update props to bring to top and use new type * fix: Reformat props * fix: Move defaults to the top * fix: Update default props to the top * fix: Update toast default props * fix: Fix storybook errors * fix: Update capwidth default prop * fix: Update comment * fix: Update popup type * fix: Pass prop down to label for proper styling * fix: Address comments, fix test * fix: Clean up props for modal and toast and header * fix: Update after merge conflicts * fix: Remove defaults for popup * fix: Update modal props Co-authored-by: Alex Nicholls <anicholls3@gmail.com>
* Add unit tests
* Add Cypress specifications
* Add visual tests
* Upgrade Popper to v2 and use canvas-kit Popper component instead of materia-ui's
This change makes it easier to create accessible tooltips. It is now possible to do this:
```tsx
<Tooltip title="Close">
<IconButton variant={IconButton.Variant.Circle} icon={xIcon} aria-label="Close" />
</Tooltip>
```
BREAKING CHANGE: Tooltip API was updated to make it easier to consume.
The original `Tooltip` did little more than add a `role="tooltip"` to a styled component. The original tooltip is now exported as `TooltipContainer` to make it easier to migrate without rewriting all tooltips. Imports will have to be updated to use the old API:
**Before:**
```ts
import { Tooltip } from '@workday/canvas-kit-react-tooltip'
```
**After:**
```ts
import { TooltipContainer as Tooltip } from '@workday/canvas-kit-react-tooltip'
```
Also with this change, the tooltip no longer gets the role `tooltip` and must be added manually.
BREAKING CHANGE: `Popper` was changed to a Functional Component with a forwarded ref. If you passed a `ref` object to `Popper` before, it will now point to the element rather than the `Popper` instance.
…day#546) * feat(core): Allow InputProvider to use a configurable container * fix: Remove state, clean up return * fix: Update api for input provider to acces refs * fix: Update the readme * fix: Uncomment input provider * fix: Remove console.warns * Update modules/core/react/README.md Co-Authored-By: Alex Nicholls <anicholls3@gmail.com> * fix: Update conditional in input provider * fix: Update variable name * fix: Add default to container prop * test: Update test for test api of input provider * Update modules/core/react/README.md Co-Authored-By: Alex Nicholls <anicholls3@gmail.com> * Update modules/core/react/README.md Co-Authored-By: Alex Nicholls <anicholls3@gmail.com> * Update modules/core/react/lib/InputProvider.tsx Co-Authored-By: Alex Nicholls <anicholls3@gmail.com> * fix: Update variable name Co-authored-by: Alex Nicholls <anicholls3@gmail.com>
* docs: Add updates to migration guide * docs: Add changelog entry for 4.0.0-beta.1 * chore: Bump modules to v4.0.0-beta.1
* fix: Update focus ring api * chore: Promote functions out of labs * fix: Get app rendering again * chore: Move styled function into core * fix: Move over styled and usetheme to common * fix: Update import to make test pass * fix: Update focus ring api * fix: Update focus for radio and checkbox * fix: Update focus ring for switch * fix: Update focus ring with default params * fix: Update dependency for core * fix: Update dep for labs core * fix: Update version * fix: Update color reset focus ring * fix: Update focus ring params * fix(common): Update types to avoid duplicate defaults * fix(common): Add missing default Co-authored-by: Alex Nicholls <anicholls3@gmail.com>
…ter-into-prerelease/v4 # Conflicts: # .travis.yml
* fix: Update readme for toolbar icon button * fix: Remove extra space * docs(button): Extra cleanup to readme * docs(button): Extra cleanup to readme * docs(button): Add missing divider to readme Co-authored-by: Alex Nicholls <anicholls3@gmail.com>
chore(button): Capitalize visual testing story filenames test(button): Move theming visual testing to separate CSF files test(button): Add CSF visual tests for ToolbarIconButton chore(button): Remove old visual testing file test(button): Add CSF story files for new button components test(button): Make common state table columnProps reusable fix(form-field): Fix text input visual testing story categorization fix(button): Calculate permutateProps to avoid storysource addon issue chore(select): Fix comments lost in merge test(select): Add CSF visual tests for theming fix(button): Fix categorization for icon button testing story fix(button): Fix empty rows on toolbar icon button stories test(button): Fix story organization for visual testing stories chore: Add linting changes that somehow didn't get committed chore(button): Remove hyperlink theming story since it can't be themed fix(button): Fix text button visual testing stories fix(radio): Fix radio group selection on visual testing story
chore: Update prerelease/v4 with latest master
* feat: Add dropdown icon button * feat: Add dropdown icon button * fix: Remove react from import * fix: Clean up styles for dropdown button * fix: Rename function and clean css * fix: Add to the readme about dropdown button * fix: Update section for dropdown * fix: Move styles into styled function * fix: Update code with comment * fix: Update styles and readme to be more clear * fix: Remove title attribute from readme * fix: Deleted story with wrong name * fix: Extend toolbar icon button props * fix: Remove container styles from function * fix: Update to use new visual testing structure * fix: Remove old visual stories * Update modules/button/react/stories/visual-testing/theming/stories_ToolbarDropdownButton.tsx Co-authored-by: Alex Nicholls <anicholls3@gmail.com> * Update modules/button/react/stories/visual-testing/theming/stories_ToolbarIconButton.tsx Co-authored-by: Alex Nicholls <anicholls3@gmail.com> * fix: Update states table * fix: Remove square text Co-authored-by: Alex Nicholls <anicholls3@gmail.com>
* test(card): Add new stories and enable snapshots * fix: Add dev dep for core * fix: Add labs core to package * fix: Update name of story
) * fix(common): Auto-generate contrast color for partial theme fix Workday#697 * refactor(common): Return undefined when no color in pickForegroundColor * fix(common): Default color in fillPalette contrast If the color passed in isn't a valid one, foreground will be undefined. this provides a fallback * fix(common): Behavior to favor lightColor when above 4.5 Co-authored-by: Donovan Gini <donovan.gini@workday.com> Co-authored-by: Alex Nicholls <anicholls3@gmail.com>
Fixes Workday#182 Adds a popup stack manager to Canvas Kit. This popup stack is framework agnostic and meant to be used globally throughout an entire application stack. It takes care to normalize z-index values, escape key handling, and click outside handling. Components have been modified to use this stack so that escape key and click outside listeners work with other popups in the stack. This is needed for accessibility requirements and so that Canvas Kit can work with other popup systems (so long as those popup systems consume this stack). BREAKING CHANGES: * Popper has been moved to the Popup module and out of common * `closeOnEscape` has been removed from the Modal component as it is no longer needed
* chore: Upgrade @workday/canvas-colors-web dependency * fix: Typing fixes after upgrading @workday/canvas-colors-web * docs: Update migration guide with breaking changes * fix(icon): Fix error in icon after upgrading colors
…ter-into-prerelease/v4 # Conflicts: # modules/avatar/react/package.json # modules/avatar/react/stories/stories.tsx # modules/avatar/react/stories/stories_visualTesting.tsx # modules/common/react/lib/Popper.tsx # modules/modal/react/package.json # modules/tooltip/react/lib/Tooltip.tsx # modules/tooltip/react/package.json # modules/tooltip/react/stories/visual.tsx
…erelease/v4 Merge/master into prerelease/v4
* feat(common): Add utility fn for static uuids for functional components * refactor(checkbox): Update to FC and use theme contrast for check * refactor(radio): Update to FC and use theme contrast for check * refactor(switch): Update to FC and use theme contrast for check * test: Add custom contrast color for testing * chore: Fix dependencies * fix(button): Fix incorrectly themed OutlineButton
…#726) * fix(button): Use correct background colors for toolbar buttons * refactor(common): Change focusRing API to make inset more configurable * fix(button): Use inset focus ring for text button by 2px * docs: Update migration guide * chore(common): Prevent type widening on entire test object
* fix(input): Enable visual regressions for Radio component
* fix(segmented-control): Use correct categorization for story * test(segmented-control): Switch to CSF and enable snapshots * docs(segmented-control): Remove labs note from readme * test(segmented-control): Add visual testing story * fix(segmented-control): Use theme color for toggled border & background
…rge/master-into-prerelease/v4 # Conflicts: # modules/_labs/core/react/lib/theming/useTheme.ts # modules/_labs/core/react/lib/type.ts # modules/_labs/drawer/react/lib/DrawerHeader.tsx # modules/core/react/lib/type.ts # modules/core/react/package.json
…erelease/v4 Merge/master into prerelease/v4
* feat(select): Render menu using a portal * feat(select): Add prop for auto-focusing menu * fix(select): Fix focus when clicking button to dismiss the menu * feat(select): Allow menu to be displayed above button * fix(select): Account for slight misalignment of menu Accounts for fractional placement of reference button (e.g., if button is placed in a horizontally-centered modal). * feat(select): Add ability to disable auto-flipping of menu * fix(select): Ensure proper support within Modal * fix(select): Fix scrolling breakage after using Popper * refactor(select): Move Popper code to SelectMenu * refactor(select): Move state from SelectBase to SelectMenu * fix(select): Resize menu on window resize * feat(select): Add flip prop to SelectBase * chore(select): Clean up stories * fix(select): Fix scrolling quirk with IE11 * fix(select): Add missing Popper dependency * chore(select): Remove extraneous selector code * chore(select): Remove more extraneous selector code * refactor(select): Convert SelectMenu back into FC using hooks * chore(select): Remove test code * refactor(select): Integrate stack manager * fix(select): Reorganize scrolling code and fix IE11 issue Fix issue with IE11 not scrolling the selected option into view when displaying the menu * chore(select): Improve comments * test(select): Move portal test story * docs(select): Update README * fix(select): Fix imports in testing stories * fix(select): Improve menu alignment with button * fix(select): Ensure menu remains aligned with its reference button Even if that means the menu is rendered out of view * fix(select): Fix hook and typescript issues * chore(select): Rename props to better convey intent * test(select): Use useModal hook for testing story * chore(select): Add missing key to testing story * chore(select): Remove unnecessary offset arguments * chore: Export PopperJS Rect from CK Popper * fix(select): Fix menu flicker * fix(modal): Fix centering issue in Chrome * docs: Added an inline comment for why width is important * test(modal): Fix tests for changes to Modal * feat(select): Optimize menu width measurement Co-authored-by: Nicholas Boll <nicholas.boll@gmail.com> * chore: Remove PopperJS Rect export from CK Popper No longer needed now that we're not using skidding Co-authored-by: Nicholas Boll <nicholas.boll@workday.com> Co-authored-by: Nicholas Boll <nicholas.boll@gmail.com>
* build: Add bump:prerelease script for prerelease alpha/beta releases * chore: Release v4.0.0-beta.5 * docs: Add latest merge to changelog
…und (Workday#740) * docs(button): Fix story categorization * fix(button): Fix outline button background on mouse focus + mouseout
When the menu is activated
* fix: Fix some more issues from colors upgrade * fix(common): Use findKey correctly and add a test
…ter-into-prerelease/v4 # Conflicts: # CHANGELOG.md # lerna.json # modules/_canvas-kit-react/package.json # modules/_labs/color-picker/react/package.json # modules/_labs/combobox/react/package.json # modules/_labs/core/react/package.json # modules/_labs/drawer/react/package.json # modules/_labs/header/react/package.json # modules/_labs/menu/react/package.json # modules/_labs/pagination/react/package.json # modules/_labs/select/react/package.json # modules/action-bar/react/package.json # modules/avatar/react/package.json # modules/badge/react/package.json # modules/banner/react/package.json # modules/button/react/package.json # modules/card/react/package.json # modules/checkbox/react/package.json # modules/color-picker/react/package.json # modules/common/react/package.json # modules/cookie-banner/react/package.json # modules/core/react/package.json # modules/form-field/react/package.json # modules/icon/react/package.json # modules/layout/react/package.json # modules/loading-animation/react/package.json # modules/modal/react/package.json # modules/page-header/react/package.json # modules/popup/react/package.json # modules/radio/react/package.json # modules/select/react/package.json # modules/side-panel/react/package.json # modules/skeleton/react/package.json # modules/status-indicator/react/package.json # modules/switch/react/package.json # modules/table/react/package.json # modules/text-area/react/package.json # modules/text-input/react/package.json # modules/toast/react/package.json # modules/tooltip/react/package.json
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
lychyi
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.0.0 (2020-06-15)
The changes below are the consolidation of changes made across all 4.0.0 beta versions (
v4.0.0-beta.0-5).To review the breaking changes made in this release, check out the v4.0.0 Migration Guide.
Infrastructure
Theming
Components