Fail on non-dev packages with executables that are only used within bin/
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Comment on lines
+24
to
+25
| # - name: Check formatting | ||
| # run: dart format --output=none --set-exit-if-changed . |
There was a problem hiding this comment.
Formatting hasn't been ran on the repo in awhile due to the matrix.sdk == 'stable' check
Will put up a different PR, running formatting, so as to not obscure the changes here with formatting diffs
dustyholmes-wf
previously approved these changes
Mar 11, 2024
evanweible-wf
previously approved these changes
Mar 28, 2024
matthewnitschke-wk
dismissed stale reviews from evanweible-wf and dustyholmes-wf
via
6a5c96c
Merged
|
This feature has been absorbed in the #111 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
dependency_validator passes if there is a non-dev (
dependencies:) dep, that contains executables, but is only referenced within thebin/directoryUnder the following conditions, the dependency should be downgraded to a dev_dependency, and dependency_validator exits with a non-zero exit code
Important
Merging this PR has a chance to break existing implementations, we may want to do this as a major, depending on how best we want to support current implementations of dep validator