FEA-3682: v4 #111
Merged
FEA-3682: v4 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
todbachman-wf
previously approved these changes
Apr 25, 2024
| @@ -647,7 +696,7 @@ void main() { | |||
| version: 0.0.0 | |||
| private: true | |||
| environment: | |||
| sdk: '>=2.4.0 <3.0.0' | |||
| sdk: '>=2.12.0 <4.0.0' | |||
There was a problem hiding this comment.
bounds of these were expanded so we can run pub get with dart 3
todbachman-wf
approved these changes
Apr 26, 2024
evanweible-wf
approved these changes
Apr 29, 2024
.github/workflows/dart_ci.yaml
Outdated
Comment on lines
15
to
17
| strategy: | ||
| matrix: | ||
| sdk: [ 2.19.6 ] |
There was a problem hiding this comment.
We should probably get this running on Dart stable as well
There was a problem hiding this comment.
Looks like this comment is a bit old, we're running on stable now: https://github.com/Workiva/dependency_validator/pull/111/files#diff-0530c3bf28665689d37061f6d19aade372700afec3ae45decc3f2edbd64e344dR18
|
semver +1 |
|
QA +1
🚀 @Workiva/release-management-p 🚢 |
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEA-3682
Motivation
Includes changes from both:
bin/#107Any current consumers of dependency_validator might encounter failures due to these changes, merging into a single v4 branch, and will be released as a major to specifically inform the "breaking" changes