Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented dart ast parsing for import/export usage #108

Closed
wants to merge 1 commit into from

Conversation

matthewnitschke-wk
Copy link
Contributor

@matthewnitschke-wk matthewnitschke-wk commented Mar 12, 2024

Motivation

There's been a long standing bug with dependency_validator, where if an import or export within dart source exists within a commented out code block, it will still be treated as if it was a valid import/export

This PR addresses this issue by implementing ast parsing of the dart files, and selects all package names based off of Directive nodes.

Closes #21

QA

tbd

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@matthewnitschke-wk matthewnitschke-wk changed the title implemented ast parsing validation implemented dart ast parsing dependency_validation Mar 12, 2024
@matthewnitschke-wk matthewnitschke-wk changed the title implemented dart ast parsing dependency_validation Implemented dart ast parsing dependency_validation Mar 12, 2024
@matthewnitschke-wk matthewnitschke-wk changed the title Implemented dart ast parsing dependency_validation Implemented dart ast parsing for import/export usage Mar 12, 2024
@matthewnitschke-wk matthewnitschke-wk mentioned this pull request Apr 24, 2024
@matthewnitschke-wk
Copy link
Contributor Author

This feature has been absorbed in the #111 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UIP-3197 Ignore imports in strings
3 participants