UIP-2615 Redraw only once when store triggers along with ancestor rerender #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
pubspec.yaml
Outdated
| w_flux: | ||
| git: | ||
| url: git@github.com:greglittlefield-wf/w_flux.git | ||
| ref: 189a1f97d95e0e3c446a5192c54e890fa61ebfb4 # from multiple_flux_redraws |
There was a problem hiding this comment.
TODO bump min w_flux version once Depends on w_flux PR: Workiva/w_flux#96 is released
trentgrover-wf
approved these changes
Aug 8, 2017
trentgrover-wf
approved these changes
Aug 8, 2017
|
Great to see this. It has been rough on us. FYI @kylemcmorrow-wf. |
rmconsole3-wf
changed the title
|
+1 |
aaronlademann-wf
added
area-component_base
State: dependent PR
Type: enhancement
and removed
Dependent PR
labels
|
@greglittlefield-wf Can you bump the w_flux dep since the change got released? |
|
@jacehensley-wf The w_flux PR was merged, but hasn't been released just yet. |
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 94.36% 94.36% +0.01%
==========================================
Files 31 31
Lines 1540 1541 +1
==========================================
+ Hits 1453 1454 +1
Misses 87 87 |
maxwellpeterson-wf
approved these changes
Aug 14, 2017
|
QA +10
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Workiva/w_flux#96
Ultimate Problem
Flux components were rerendered excessively when nested inside each other and a store trigger caused rerendering of those nested components.
See reduced test case here.
Solution
Track whether components were already redrawn during the current redraw batch.
All consumers will need to do is make sure to call
super.componentDidUpdatein overrides, and they'll get this fix.Testing
Areas of Regression
Flux component rerendering
FYA @Workiva/web-platform-pp @Workiva/ui-platform-pp
FYI: @kylemcmorrow-wf @johnbland-wf @brentschuele-wf @brandonrodgers-wf @robbielamb-wf