Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-4936 UIP-2639 Release over_react 1.16.2 (HOTFIX) #110

Merged
merged 5 commits into from
Aug 16, 2017
Merged

Conversation

greglittlefield-wf
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf commented Aug 16, 2017

Ultimate problem:

Some consumers have found issues in 1.16.0 and 1.16.1 with FluxUiComponents rendering.

How it was fixed:

The root issue is unknown, but is related to bugfixes/enhancements around FluxUiComponent rendering. The following have been reverted

Testing suggestions:

  • Verify tests pass
  • Pull into markup and verify that there are no rendering regressions

Potential areas of regression:

FluxUiComponent


FYA: @greglittlefield-wf @aaronlademann-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf

@aviary-wf
Copy link

aviary-wf commented Aug 16, 2017

Raven

Number of Findings: 0

@rmconsole-wf rmconsole-wf changed the title Release over_react 1.16.2 (HOTFIX) WP-4936 UIP-2639 Release over_react 1.16.2 (HOTFIX) Aug 16, 2017
@aaronlademann-wf
Copy link
Contributor

+1

@codecov-io
Copy link

codecov-io commented Aug 16, 2017

Codecov Report

Merging #110 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   94.37%   94.37%   -<.01%     
==========================================
  Files          31       31              
  Lines        1544     1543       -1     
==========================================
- Hits         1457     1456       -1     
  Misses         87       87

@leviwith-wf
Copy link
Contributor

QA +10

  • tests pass
  • markup example renders as expected on initial load

  • Dev +1’s on MPR
  • Dev +1’s present on related CRs (this one)
  • Version info updated
  • Rosie ran / comment displays expected info
  • Dependency Scan Clean

Ready for merge and tag.

@leviwith-wf leviwith-wf merged commit c968d22 into master Aug 16, 2017
@greglittlefield-wf greglittlefield-wf deleted the 1.16.2-wip branch February 26, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants