UIP-2762 More convenient ubiquitous access of DOM/aria props

[greglittlefield-wf]

Ultimate problem:

I was bored after work yesterday 😄

Adding aria/DOM props to components is a little clunky; you have to do something like this:

(Button()
  ..addProps(domProps()..draggable = true)
  ..addProps(ariaProps()
    ..controls = 'my_popover'
    ..labelledby = 'my_label'
  )
)('Click me')

What would be nicer is a syntax like this:

(Button()
  ..dom.draggable = true
  ..aria.controls = 'my_popover'
  ..aria.labelledby = 'my_label'
)('Click me')

How it was fixed:

• Add aria and dom getters to UbiquitousDomPropsMixin that provide typed views into a given UiProps class that allow for reading/writing aria/DOM props.
• Add doNotGenerate option to @Accessor() annotation to allow declaring fields in accessor (props, props mixin, state, state mixin) classes that shouldn't be generated into key-value-pair-backed getters/setters.
  • Necessary to implement caching for aria/dom getters.

Testing suggestions:

• Verify that tests pass.
• Render a component with the above syntax and verify that things work as expected.

Potential areas of regression:

This could break consumer code if they've declared props named aria or dom.

---

FYA: @greglittlefield-wf @aaronlademann-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf

[aviary-wf]

Raven

Number of Findings: 0

[aaronlademann-wf]

+1

[jacehensley-wf]

Should we add a constant annotation for this? @doNotGenerate obviously not needed for this PR but might be nice for later

[greglittlefield-wf]

Yeah, I thought about adding one but decided against it since this won't be used very often (we haven't had a need for it until now).

[jacehensley-wf]

QA +10

• Build successful
• tests pass

---

• Testing instruction
• Dev +1's
• Unit tests created/updated
• All unit tests pass
• Rosie ran/Rosie comment displays expected info
• Dependency Scan Clean

Merging.