Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-5222 UIP-2741 Release over_react 1.18.0 #121

Merged
merged 2 commits into from
Oct 17, 2017

Conversation

rmconsole-readonly-wk
Copy link
Contributor

Pulls Included in Release:

Requested by: @jacehensley-wf

Diff Between Last Tag and Proposed Release: 1.17.0...Workiva:release_over_react_1_18_0
Diff Between Last Tag and New Tag: 1.17.0...1.18.0

The logs for the request that created this PR can be found here

@rmconsole-wf rmconsole-wf changed the title Release over_react 1.18.0 WP-5222 UIP-2741 Release over_react 1.18.0 Oct 17, 2017
@aviary-wf
Copy link

aviary-wf commented Oct 17, 2017

Raven

Number of Findings: 0

@codecov-io
Copy link

codecov-io commented Oct 17, 2017

Codecov Report

Merging #121 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #121   +/-   ##
=======================================
  Coverage   94.42%   94.42%           
=======================================
  Files          31       31           
  Lines        1559     1559           
=======================================
  Hits         1472     1472           
  Misses         87       87

@greglittlefield-wf
Copy link
Contributor

We need to update CHANGELOG.md, right? I wish we had that step automated...

@jacehensley-wf
Copy link
Contributor

Yep, I can push a commit up to do that

@greglittlefield-wf
Copy link
Contributor

+1

@aaronlademann-wf
Copy link
Contributor

QA +1

  • Dev +1's
  • All unit tests pass
  • Rosie ran/Rosie comment displays expected info
  • Dependency Scan Clean

Merging.

@aaronlademann-wf aaronlademann-wf merged commit 10ab856 into master Oct 17, 2017
@aaronlademann-wf aaronlademann-wf deleted the release_over_react_1_18_0 branch October 17, 2017 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants