changed react_dom.render(FooComponent()() to react_dom.render(Foo()() #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example code always uses: ```dart @factory() UiFactory<FooProps> Foo; ``` So shouldn't Foo also be used in the initial render call? FooComponent is a bit misleading.
RavenNumber of Findings: 0 |
Current coverage is 97.03% (diff: 100%)@@ master #16 diff @@
==========================================
Files 27 27
Lines 1211 1211
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1175 1175
Misses 36 36
Partials 0 0
|
|
Good catch. |
johncblandii
added a commit
to johncblandii/over_react
that referenced
this pull request
Oct 29, 2016
The README code does not compile because it looks for `react_client`. Workiva#16 is needed to make the code actually run as well.
|
+1 |
1 similar comment
|
+1 |
|
RM +1 manually reviewed dependencies. |
clairesarsam-wf
pushed a commit
to clairesarsam-wf/over_react
that referenced
this pull request
Jan 6, 2017
The README code does not compile because it looks for `react_client`. Workiva#16 is needed to make the code actually run as well.
clairesarsam-wf
pushed a commit
to clairesarsam-wf/over_react
that referenced
this pull request
Jan 6, 2017
changed react_dom.render(FooComponent()() to react_dom.render(Foo()()
greglittlefield-wf
added a commit
that referenced
this pull request
Jun 19, 2020
Clean up deprecations, improve type checking for core types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example code always uses:
So shouldn't Foo also be used in the initial render call? FooComponent is a bit misleading.