Fix react_client reference in README #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The README code does not compile because it looks for `react_client`. Workiva#16 is needed to make the code actually run as well.
RavenNumber of Findings: 0 |
Current coverage is 97.03% (diff: 100%)@@ master #18 diff @@
==========================================
Files 27 27
Lines 1211 1211
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1175 1175
Misses 36 36
Partials 0 0
|
|
+1 |
|
RM +1 manually reviewed dependencies |
greglittlefield-wf
added a commit
that referenced
this pull request
Jun 19, 2020
Update addRef assist / add createRef quick fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
The README code does not run.
How it was fixed:
Named the import
react_clientso the example code runs.Testing suggestions:
Paste code and verify it runs.
Potential areas of regression:
None.
The README code does not compile because it looks for
react_client.#16 is needed to make the code actually run as well.