Corrected a mistake in ReadMe.md "Using it in your project" 4. #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
antonin-lebrard
changed the title
|
same as #18 |
|
Sorry for the typo @antonin-lebrard! Fix has been merged to master via #18. |
greglittlefield-wf
added a commit
that referenced
this pull request
Jun 19, 2020
Incorrect Doc Comment Location Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
Just a small mistake in the code proposed as an entry point to the over_react library.
At the fouth point in "Using it in your project" the import "react/react_client.dart"was missing the name re-definition "as react_client".
And the top-level function called in this import could not be called in the main.
How it was fixed:
Changed :
import 'package:react/react_client.dart'To :
import 'package:react/react_client.dart' as react_client;Testing suggestions:
N/A
Potential areas of regression:
N/A