Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-3093 Add ErrorBoundary Component #266

Merged

Conversation

aaronlademann-wf
Copy link
Contributor

Ultimate problem:

In preparation for React16 error boundary capabilities, we should provide a canonical ErrorBoundary component.

How it was fixed:

Add the ErrorBoundary component.

NOTE: This component doesn't actually hook into any ReactJS lifecycle yet. It won't until support for ReactJS 16 is added to react-dart in version 5.0.0, and to over_react in version 3.0.0.

The wiring for those lifecycle methods will be implemented in a follow-up ticket, and merged into the 3.0.0-wip branch.

Testing suggestions:

  • Passing CI

Potential areas of regression:

None, new feature only.


FYA: @greglittlefield-wf @kealjones-wk

+ In preparation for React16 error boundary capabilities!
@aaronlademann-wf aaronlademann-wf requested a review from a team as a code owner March 8, 2019 21:21
@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment otherwise looks great!

lib/src/component/error_boundary.dart Outdated Show resolved Hide resolved
Co-Authored-By: aaronlademann-wf <aaron.lademann@workiva.com>
@aaronlademann-wf
Copy link
Contributor Author

+1 to Greg's suggestion

@greglittlefield-wf
Copy link
Contributor

+10

@aaronlademann-wf
Copy link
Contributor Author

@Workiva/release-management-pp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants