-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPLAT-5397: Add isErrorBoundary argument to the @Component2 annotation #293
Conversation
…ent-apis' into 5397
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start @tainhenning-wk !
...t/component_declaration/builder_integration_tests/component2/component_integration_test.dart
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
+1 refresh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA +1
@Workiva/release-management-pp |
Motivation
Add
isErrorBoundary
argument to the new@Component2()
annotation, allowing the use of thecomponentDidCatch
andgetDerivedStateFromError
lifecycle methods. This makes it possible for custom components to act as React error boundaries instead of having to be wrapped by the defaultErrorBoundary
HOC.Changes
Added isErrorBoundary argument
Added skipMethods override
Added tests
Release Notes
Allow custom components to act as React error boundaries.
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: