Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM-89097 RM-89096 Release over_react 4.0.0 #647

Merged
merged 32 commits into from
Jan 19, 2021

Conversation

rmconsole-readonly-wk
Copy link
Contributor

@rmconsole-readonly-wk rmconsole-readonly-wk commented Nov 24, 2020

This stable, major release of over_react includes:

ReactJS 17.x Support

The underlying .js files provided by the react-dart 6.0.0 release are now ReactJS version 17.0.1.


Breaking Changes

ReactJS 17 Breaking Changes

Source: https://reactjs.org/blog/2020/08/10/react-v17-rc.html#other-breaking-changes

React 17 includes some breaking changes, but rather than being large API removals, they are mostly subtle behavior changes of existing APIs. Please refer to their blog post for all behavior changes.

Dart API Breaking Changes

All of the Dart API breaking changes come from re-exports of members of the react package. Check out the react 6.0.0 breaking changes for more information.

@rm-astro-wf rm-astro-wf changed the title Release over_react 4.0.0 RM-89097 RM-89096 Release over_react 4.0.0 Nov 24, 2020
@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@joebingham-wk
Copy link
Contributor

All commits after 03d73c8 are unreviewed - but the only changes are to the changelog, the root pubspec, and the todo app pubspec

sydneyjodon-wk
sydneyjodon-wk previously approved these changes Dec 2, 2020
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@@ -45,6 +45,6 @@
/// ),
/// ])(_$BigBlock);
/// ```
R Function(A) composeHocs<R, A extends R>(Iterable<R Function(A)> functions) {
R Function(R) composeHocs<R>(Iterable<R Function(R)> functions) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes a bad implicit cast in the implementation and shouldn't affect consumers.

Thankfully, there are no consumers, so we know it won't affect any 😄 : https://sourcegraph.wk-dev.wdesk.org/search?q=composeHocs&patternType=literal

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aaronlademann-wf
Copy link
Contributor

Semver +1

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit ae1514b into master Jan 19, 2021
@rmconsole6-wk rmconsole6-wk deleted the release_over_react_4.0.0 branch January 19, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants