Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE React 17 Testing #171

Closed

Conversation

sourcegraph-wk
Copy link

@sourcegraph-wk sourcegraph-wk commented Dec 15, 2020

These changes / builds will first be reviewed by a member of the Client Platform team.

Repo owners will be notified when it is ready for additional review and testing.

Motivation

We need a branch that forces ReactJS 17 compatible versions of react and over_react so that CI checks and manual smoke testing can be performed with ReactJS 17 running "under the hood".

Changes

_All of the changes from the analogous master PR that opened up the upper bounds of the react and over_react dependencies, plus adding necessary dependency overrides to ensure that ReactJS 17 compatible versions of react and over_react dependencies are being used.

Review

Please review: @greglittlefield-wf @aaronlademann-wf @joebingham-wk @sydneyjodon-wk

QA Checklist

  • Passing CI
    • Verify that the pubspec.lock artifact(s) in the CI builds contain the following dependency override refs:
      • react: 6.0.0-wip
      • over_react: release_over_react_4.0.0
      • web_skin_dart: check the pubspec override (if applicable)

More information about React 17
The 6.0.0 react-dart release
The 4.0.0 over_react release

Created by Sourcegraph campaign Workiva/react_17_testing.

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@aaronlademann-wf aaronlademann-wf deleted the campaign/client_platform/react_17_testing branch January 7, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants