Raise analyzer minimum & unpin meta #804
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
| @@ -7,14 +7,14 @@ environment: | |||
|
|
|||
| dependencies: | |||
| collection: ^1.14.11 | |||
| analyzer: '>=0.40.0 <2.0.0' | |||
| analyzer: ^1.7.2 | |||
There was a problem hiding this comment.
Now that we don't support these other analyzer versions, can we remove these lines from this matrix that test on older, now-unsupported analyzer versions? https://github.com/Workiva/over_react/blob/master/.github/workflows/dart_ci.yml#L89-L91
Even though that build's redundant, you can just remove those lines and leave the matrix in place if you want, since it'll come in handy if we need to support multiple major versions.
There was a problem hiding this comment.
Actually, our Dart CI needs some cleanup to disable the failing stable build, which I can address in a separate PR.
That touches some of these lines, so I can just do that in that PR; don't worry about it for this PR.
| build: '>=1.0.0 <3.0.0' | ||
| built_redux: ">=7.4.2 <9.0.0" | ||
| built_value: ^8.0.0 | ||
| dart_style: '>=1.2.5 <3.0.0' | ||
| js: ^0.6.1+1 | ||
| logging: '>=0.11.3+2 <2.0.0' | ||
| meta: ">=1.1.6 <1.7.0" # Workaround to avoid https://github.com/dart-lang/sdk/issues/46142 | ||
| meta: ^1.6.0 # Workaround to avoid https://github.com/dart-lang/sdk/issues/46142 |
There was a problem hiding this comment.
Are these comments still applicable? If not, can we remove them?
There was a problem hiding this comment.
I can also address these in a follow up PR
|
Skynet test results failed initially for this build but were approved by greg.littlefield |
|
@Workiva/release-management-p |
rmconsole-wf
added
Merge Requirements Met
RM Ready
and removed
Merge Requirements Unmet
labels
Summary
Frontend Frameworks is updating dependencies! More details at
https://wiki.atl.workiva.net/display/CP/Dependency+Upgrades
This will require analyzer 1.7.2+ and now that we're past analyzer 1.7.1
we can unpin the meta dependency. (We had restricted it to <1.7.0 in many places)
For more info, reach out to
#support-frontend-dxon Slack.Created by Sourcegraph batch change
Workiva/analyzer1_unpin_meta.