Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise analyzer minimum & unpin meta #804

Merged
merged 1 commit into from
Feb 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/over_react_redux/todo_client/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ environment:
dependencies:
color: any
memoize: ^2.0.0
meta: ">=1.2.2 <1.7.0" # Workaround to avoid https://github.com/dart-lang/sdk/issues/46142
meta: ^1.6.0 # Workaround to avoid https://github.com/dart-lang/sdk/issues/46142
over_react: ">=3.1.5 <5.0.0"
json_annotation: ^3.0.0
redux: ">=3.0.0 <5.0.0"
Expand Down
4 changes: 2 additions & 2 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,14 @@ environment:

dependencies:
collection: ^1.14.11
analyzer: '>=0.40.0 <2.0.0'
analyzer: ^1.7.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we don't support these other analyzer versions, can we remove these lines from this matrix that test on older, now-unsupported analyzer versions? https://github.com/Workiva/over_react/blob/master/.github/workflows/dart_ci.yml#L89-L91

Even though that build's redundant, you can just remove those lines and leave the matrix in place if you want, since it'll come in handy if we need to support multiple major versions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, our Dart CI needs some cleanup to disable the failing stable build, which I can address in a separate PR.

That touches some of these lines, so I can just do that in that PR; don't worry about it for this PR.

build: '>=1.0.0 <3.0.0'
built_redux: ">=7.4.2 <9.0.0"
built_value: ^8.0.0
dart_style: '>=1.2.5 <3.0.0'
js: ^0.6.1+1
logging: '>=0.11.3+2 <2.0.0'
meta: ">=1.1.6 <1.7.0" # Workaround to avoid https://github.com/dart-lang/sdk/issues/46142
meta: ^1.6.0 # Workaround to avoid https://github.com/dart-lang/sdk/issues/46142
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these comments still applicable? If not, can we remove them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also address these in a follow up PR

path: ^1.5.1
react: ^6.1.8
redux: ">=3.0.0 <5.0.0"
Expand Down
2 changes: 1 addition & 1 deletion tools/analyzer_plugin/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ dependencies:
analyzer: ^1.7.2
analyzer_plugin: ^0.6.0
collection: ^1.15.0-nullsafety.4
meta: ^1.1.6
meta: ^1.6.0
# Upon release, this should be pinned to the over_react version from ../../pubspec.yaml
# so that it always resolves to the same version of over_react that the user has pulled in,
# and thus has the same boilerplate parsing code that's running in the builder.
Expand Down