Skip to content

Commit

Permalink
Merge pull request #179 from Workiva/extract_example
Browse files Browse the repository at this point in the history
Make example a separate pkg to remove over_react
  • Loading branch information
rmconsole6-wk authored Apr 28, 2023
2 parents d7f79c5 + 6feceba commit 3e92498
Show file tree
Hide file tree
Showing 18 changed files with 38 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dart_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
sdk: [ 2.13.4, 2.18.7 ]
sdk: [ 2.18.7, stable ]
steps:
- uses: actions/checkout@v2
- uses: dart-lang/setup-dart@v0.2
Expand Down
3 changes: 3 additions & 0 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# analysis_options.yaml docs: https://www.dartlang.org/guides/language/analysis-options
analyzer:
exclude:
- "example/**"

# Strong mode is required. Applies to the current project.
strong-mode:
# When compiling to JS, both implicit options apply to the current
Expand Down
2 changes: 2 additions & 0 deletions dart_dependency_validator.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
exclude:
- "example/**"
ignore:
# Ignore the pin on the test package while we have to avoid a bad version of test 1.18.1 https://github.com/dart-lang/test/issues/1620
- test
6 changes: 3 additions & 3 deletions example/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
w_flux Examples
================

To run the examples, open the root of this repository in a command-line terminal.
To run the examples, open the example directory of this repository in a command-line terminal.

1. `dart run dart_dev examples`
2. Open Chromium/Dartium to `http://localhost:8080`
1. `dart run build_runner serve`
2. Open `http://localhost:8080`
24 changes: 24 additions & 0 deletions example/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: w_flux_example
version: 2.10.24
description: Flux library for uni-directional dataflow inspired by reflux and Facebook's
flux architecture.
homepage: https://github.com/Workiva/w_flux
publish_to: none
environment:
sdk: ">=2.11.0 <3.0.0"
dependencies:
over_react: ">=3.12.0 <5.0.0"
w_flux:

dev_dependencies:
react: ">=5.7.0 <7.0.0"
build_runner: '>=1.7.1 <3.0.0'
build_web_compilers: ^3.0.0
dart_dev: '>=3.8.5 <5.0.0'
dart_style: ^2.1.1
dependency_validator: ^3.0.0


dependency_overrides:
w_flux:
path: ../
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
12 changes: 4 additions & 8 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,17 @@ description: Flux library for uni-directional dataflow inspired by reflux and Fa
homepage: https://github.com/Workiva/w_flux

environment:
sdk: ">=2.11.0 <3.0.0"
sdk: ">=2.11.0 <3.0.0"

dependencies:
meta: ^1.6.0
react: ">=5.7.0 <7.0.0"
w_common: '>=2.0.0 <4.0.0'

dev_dependencies:
build_runner: '>=1.7.1 <3.0.0'
build_runner: ^2.0.0
build_test: ^2.1.3
build_vm_compilers: ^1.0.11
build_web_compilers: ^3.0.0
dart_dev: '>=3.8.5 <5.0.0'
dart_style: ^2.1.1
dart_dev: ^4.0.0
dependency_validator: ^3.0.0
over_react: ">=3.12.0 <5.0.0"
# Avoid a bad version of test 1.18.1 https://github.com/dart-lang/test/issues/1620
test: ">=1.15.7 <1.18.1"
test: ^1.18.2
5 changes: 1 addition & 4 deletions tool/dart_dev/config.dart
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@

import 'package:dart_dev/dart_dev.dart';

final config = {
...coreConfig,
'serve': WebdevServeTool()..webdevArgs = ['example:8080']
};
final config = coreConfig;

0 comments on commit 3e92498

Please sign in to comment.