Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make example a separate pkg to remove over_react #179

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

robbecker-wf
Copy link
Member

@robbecker-wf robbecker-wf commented Apr 27, 2023

Motivation

The dependency on over_react isn't necessary since it is only used in the example subdir.

Changes

Move the examples to example/web dir and make the example dir a separate package.
Remove the over_react dependency from the root.

Also got CI running on Dart 2.19 and added excludes to the root analysis and dependency validator so it didn't complain that over_react is still needed.

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Architecture member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@robbecker-wf robbecker-wf marked this pull request as ready for review April 27, 2023 20:58
Copy link

@akshaybhardwaj-wk akshaybhardwaj-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robbecker-wf
Copy link
Member Author

QA+1 CI passes @Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit 3e92498 into master Apr 28, 2023
@rmconsole6-wk rmconsole6-wk deleted the extract_example branch April 28, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants