Upgrade wrensec-ui to version 23 in UI modules. #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krausvo1
commented
Feb 23, 2024
openam-ui/openam-ui-ria/src/main/js/org/forgerock/openam/ui/common/components/TabComponent.js
Show resolved
Hide resolved
|
Fixed passing of target version to gulp task during |
krausvo1
force-pushed
the
upgrade-ui
branch
3 times, most recently
from
1ea2a28
to
fe1ab26
Compare
|
I have squashed few commits. The PR is now ready for review. |
|
Loading indicator spinner sometimes stays displayed when it should be hidden after the upgrade. This is upstream issue (see WrenSecurity/wrensec-ui#36) that I think can be solved separately from this PR. |
krausvo1
force-pushed
the
upgrade-ui
branch
2 times, most recently
from
efb3158
to
dda55c1
Compare
pavelhoral
requested changes
Mar 1, 2024
...nam-ui-ria/src/main/js/org/forgerock/openam/ui/admin/views/realms/sessions/SessionsTable.jsx
Outdated
Show resolved
Hide resolved
pavelhoral
reviewed
Mar 1, 2024
openam-ui/openam-ui-ria/src/test/js/org/forgerock/openam/ui/common/util/PromiseTest.js
Outdated
Show resolved
Hide resolved
pavelhoral
reviewed
Mar 1, 2024
...i/openam-ui-ria/src/main/resources/templates/common/components/tab/TabComponentTemplate.html
Show resolved
Hide resolved
* Replace Grunt with Gulp. * Drop duplicate libraries already present in wrensec-ui and drop version numbers from local libs filenames.
… underscore dependency on its own.
…e and bundle it separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have upgraded
wrensec-uidependency to the latest release23.0.1inopenam-ui/openam-ui-apiandopenam-ui/openam-ui-riamodules.This PR primarily focuses on switching from Grunt to Gulp and adjusting code to
wrensec-uichanges and dependency upgrades (e.g. lodash).I have also upgraded CodeMirror to version 6. This could perhaps be implemented better so the usage is more convenient, but I don't think that's crucial for now since the editor is used in a single view only. Former ForgeRock editor theme is no longer used since it was deleted from
wrensec-uiand the default CodeMirror theme has improved a little since version 4.I have tested admin UI thoroughly, everything seems to work fine after the changes.